Add kwargs to ForeignKey definitions #610
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ForeignKey
definitions in SqlAlchemy accept kwargs such asonupdate
andondelete
that determine the behaviour of the foreign key at the DB level. This PR adds the option to provide kwargs to theForeignKey
definition under the hood. In my case, I used it to control delete behaviour when deleting a model that did not maintain back references (relationships) with its child models. Example -- an application where users can have 0 or 1 "Repository":If we didn't set the
ondelete="SET NULL"
option on theuser.repository_id
foreign key we would get this error:A workaround for this would be to keep a
user: User = Relationship(back_populates='repository')
attribute which I didn't want to do because in my case it would clutter my model. I'm wondering whether there are more concrete use cases for theforeign_key_kwargs
option.