update chunkermatapply interface, speed enhancements #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removes dval from chunkermatapply interface for consistency with chunkermat - adds a warning about fmms - tries to speed up kerneval_smooth in the most common situation - the previous version of corrections was slow, this avoids some slow indexing that was happening. - this adds a faster lege.barywts option when nodes are known
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pull request changes the chunkermatapply interface to be more like chunkermat. dval has been removed. it can easily be added outside of the apply (with more flexibility). see chunkermatapplyTest in devtools/test
there are some other tweaks to tests.
there is a stray update of the move function documentation.
chunkermat now computes corrections on the fly if requested. this seems to be a little faster. we can revisit this though. the downside is that there is more code duplication...