Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add peer id to submit messages logs #2343

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

aditiharini
Copy link
Contributor

@aditiharini aditiharini commented Oct 1, 2024

When there are gossip issues, it would be useful to have peer ids in the submit messages logs to identify whether the issues are isolated to certain pairs of peer ids or not.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

This PR focuses on enhancing logging functionality by including the peerId in the logs when submitting messages, allowing for better traceability of operations.

Detailed summary

  • Updated logging for successful message submissions to include peerId and infoLogs.
  • Updated logging for failed message submissions to include peerId and errorLogs.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Oct 1, 2024

🦋 Changeset detected

Latest commit: efa967a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@farcaster/hubble Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 6:32pm

@aditiharini aditiharini added the t-chore Miscellaneous improvements label Oct 1, 2024
@sds
Copy link
Member

sds commented Oct 17, 2024

Was there anything holding this back from being merged, @aditiharini?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-chore Miscellaneous improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants