Translate NUMERIC to Trino

faradayio · Oct 30, 2023 · aa634b7 · aa634b7
1 parent 359555f
commit aa634b7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/src/ast.rs b/src/ast.rs
@@ -1375,10 +1375,8 @@ impl Emit for DataType {
                 DataType::Float64(token) => token.ident.token.with_str("DOUBLE").emit(t, f),
                 DataType::Geography(token) => token.ident.token.with_str("JSON").emit(t, f),
                 DataType::Int64(token) => token.ident.token.with_str("BIGINT").emit(t, f),
-                // TODO: This cannot be done safely in Trino, because you always
-                // need to specify the precision and where to put the decimal
-                // place.
-                DataType::Numeric(token) => token.ident.token.with_str("DECIMAL(?,?)").emit(t, f),
+                // BigQuery's precision is fixed, and we can't change it.
+                DataType::Numeric(token) => token.ident.token.with_str("DECIMAL(38,9)").emit(t, f),
                 DataType::String(token) => token.ident.token.with_str("VARCHAR").emit(t, f),
                 DataType::Time(token) => token.emit(t, f),
                 DataType::Timestamp(token) => token

diff --git a/tests/sql/data_types/numeric.sql b/tests/sql/data_types/numeric.sql
@@ -1,5 +1,3 @@
--- pending: trino BigQuery NUMERIC may lose data when converted to DECIMAL(n,m).
-
 -- Test type parsing without creating any actual rows. This allows us to
 -- verify as many types as possible without needing to worry about reading
 -- data from the database.