-
Notifications
You must be signed in to change notification settings - Fork 74
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #209 from fanyuyen/master
[bug] fix pmcx dettpsf overwrites input bug, close #208
- Loading branch information
Showing
1 changed file
with
5 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@fanyuyen, I think there is a bug here:
detid
can be greater than 0xFF=255.mcx can accommodate at most 4000 src+det+medium combined, see
https://github.com/fangq/mcx/blob/51003bc6d5540285be16d581f9abcb488852df24/src/mcx_const.h#L57C1-L58C1
if you look at the original matlab code, I used
0xFFFF
mcx/utils/mcxdetphoton.m
Line 43 in 51003bc
can you submit another PR and fix this? (and double check to see if this appears elsewhere).
please also add
[bug]
and add#209
in your commit message so it will be linked here.thanks