added tag_keys_field #88
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is to address #75
In the issue it was suggested to use 'tag_keys_field' to point to a element which contains list of fields which should be set as tags.
But the implementation used in this pull request is that 'tag_keys_field' will point to an hash element which contains key/value pair.
This small deviation is taken due to the performance reason. Getting list of tag names, adding them to the tags and then deleting them from the fields takes too much time and is impacting scenarios at scale.
Hence this implementation where 'tag_keys_field' will point to an hash element which contains key/value pair.