Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore truncated lines to avoid parsing errors #299

Merged
merged 3 commits into from
Jan 16, 2024

Conversation

Issif
Copy link
Member

@Issif Issif commented Jun 30, 2023

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area plugins

/area registry

/area build

/area documentation

What this PR does / why we need it:

AWS Cloudwatch Logs truncates log lines with more than 10,000 characters, as these lines can't be parsed by the plugin they are now ignored.

Which issue(s) this PR fixes:

#297

Fixes #

Special notes for your reviewer:

@leogr
Copy link
Member

leogr commented Sep 14, 2023

any updates on this? 🤔

@Issif
Copy link
Member Author

Issif commented Sep 14, 2023

any updates on this? 🤔

Still need to do the suggestion @jasondellaluce proposed. No way to "fix" the json sadly

@leogr
Copy link
Member

leogr commented Nov 24, 2023

Is this still needed? 🤔

cc @Issif @jasondellaluce

N.B. I'm just assigning this to my self to track it
/assign

@Issif
Copy link
Member Author

Issif commented Nov 24, 2023

I need to work on that. I post poned because of the kubecon, will see next week

Copy link

Rules files suggestions

Copy link

Rules files suggestions

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM.

@jasondellaluce ?

@poiana poiana added the lgtm label Jan 16, 2024
@poiana
Copy link
Contributor

poiana commented Jan 16, 2024

LGTM label has been added.

Git tree hash: 9458842ac912cfd28fa22908f2a3d9450f992a5c

@poiana
Copy link
Contributor

poiana commented Jan 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Issif, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 612f126 into falcosecurity:master Jan 16, 2024
13 checks passed
@abeleon-m1
Copy link

should this be resolved in 0.3.0? still seeing the same in 0.4.0?

@leogr
Copy link
Member

leogr commented May 10, 2024

should this be resolved in 0.3.0? still seeing the same in 0.4.0?

Hey @abeleon-m1

This fix has been released in 0.4.0 (and not in 0.3.0).

Have you encountered the same problem in 0.4.0? 🤔
If so, can you post on #297 (or submit a new issue) and share all the details? We would need to reproduce the problem. Thanks in advance.

cc @Issif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants