fix(pkg/cgo): solve data races when assigning/deleting and accessing handles #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…handles Signed-off-by: Jason Dellaluce <[email protected]>
poiana
added
kind/bug
…rker Signed-off-by: Jason Dellaluce <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jasondellaluce, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: f587a2dd6637a357c6ac975c28939f730ce508ef
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind cleanup
Any specific area of the project related to this PR?
/area plugin-sdk
What this PR does / why we need it:
Due to how shared object loading works in Linux and in the falcosecurity libs, I discovered that concurrent (and legitimate, as per generalized non-Falco libs consumers) operations to plugins written in Go led to panics and segfaults caused by data races in case of many workers.
So far my research led to discovering that this kind of issues disappear when re-working the
cgo.Handleprimitives to support proper synchronization.Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: