Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: chore(ci): improve e2e CI run time by avoiding caching build folder and the bundled deps build #2074

Closed
wants to merge 2 commits into from

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Sep 20, 2024

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area CI

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@FedeDP FedeDP changed the title chore(ci): improve e2e CI run time by avoiding caching build folder and the bundled deps build wip: chore(ci): improve e2e CI run time by avoiding caching build folder and the bundled deps build Sep 20, 2024
@poiana
Copy link
Contributor

poiana commented Sep 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

… and splitting the CI in 2 jobs.

Signed-off-by: Federico Di Pierro <[email protected]>
Copy link

github-actions bot commented Sep 20, 2024

Perf diff from master - unit tests

     4.95%     +1.27%  [.] next
     5.58%     +1.01%  [.] sinsp_evt::get_type
     6.83%     +0.89%  [.] sinsp::next
     2.31%     -0.81%  [.] scap_event_decode_params
     2.66%     -0.77%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node
     1.86%     -0.61%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release
     1.49%     -0.52%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char const*>
     2.58%     +0.50%  [.] sinsp_thread_manager::find_thread
     0.75%     -0.49%  [.] scap_file_test_helpers::capture_search_evt_by_num
     4.95%     -0.46%  [.] sinsp_parser::process_event

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            -0.0048         -0.0048           151           150           151           150
BM_sinsp_split_median                                          -0.0045         -0.0045           150           150           150           150
BM_sinsp_split_stddev                                          +0.9165         +0.9165             1             1             1             1
BM_sinsp_split_cv                                              +0.9256         +0.9257             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.1369         +0.1369            41            47            41            47
BM_sinsp_concatenate_paths_relative_path_median                +0.1374         +0.1373            41            47            41            47
BM_sinsp_concatenate_paths_relative_path_stddev                +0.7141         +0.7131             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_cv                    +0.5077         +0.5068             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0154         -0.0154            17            17            17            17
BM_sinsp_concatenate_paths_empty_path_median                   -0.0093         -0.0093            17            17            17            17
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.2162         -0.2165             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.2039         -0.2042             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  +0.1034         +0.1034            45            50            45            50
BM_sinsp_concatenate_paths_absolute_path_median                +0.1060         +0.1060            44            49            44            49
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.0163         -0.0160             1             1             1             1
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.1085         -0.1082             0             0             0             0
BM_sinsp_split_container_image_mean                            -0.0089         -0.0089           349           346           349           346
BM_sinsp_split_container_image_median                          -0.0082         -0.0082           349           346           349           346
BM_sinsp_split_container_image_stddev                          -0.0890         -0.0883             3             2             3             2
BM_sinsp_split_container_image_cv                              -0.0808         -0.0801             0             0             0             0

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.58%. Comparing base (6013891) to head (42e73d0).
Report is 11 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2074   +/-   ##
=======================================
  Coverage   73.58%   73.58%           
=======================================
  Files         253      253           
  Lines       31867    31867           
  Branches     5620     5653   +33     
=======================================
  Hits        23449    23449           
- Misses       8387     8418   +31     
+ Partials       31        0   -31     
Flag Coverage Δ
libsinsp 73.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FedeDP
Copy link
Contributor Author

FedeDP commented Sep 20, 2024

/milestone TBD

Using non-bundled grpc leads to test failures.

@poiana poiana added this to the TBD milestone Sep 20, 2024
Signed-off-by: Federico Di Pierro <[email protected]>
@FedeDP
Copy link
Contributor Author

FedeDP commented Sep 24, 2024

/close

@poiana poiana closed this Sep 24, 2024
@poiana
Copy link
Contributor

poiana commented Sep 24, 2024

@FedeDP: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants