wip: fix(pkg/driverbuilder): fixed bpf probe build for new libs. #283
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Most of the changes are in:
Also, i had to update all target templates so that:
|
FedeDP
force-pushed
the
fix/bpf_build_new_libs
branch
from
5d82d5e
to
8f8a761
Compare
| "fill-driver-config.sh": bufFillDriverConfig.String(), | ||
| "downloader.sh": waitForLockAndCat, | ||
| "unlock.sh": deleteLock, | ||
| }, | ||
| } | ||
| if c.BuildModule() { |
There was a problem hiding this comment.
Only copy them if needed.
| {"/driverkit/fill-driver-config.sh", bufFillDriverConfig.String()}, | ||
| } | ||
| if c.BuildModule() { |
There was a problem hiding this comment.
Only copy them if needed.
| MakeObjList string | ||
| } | ||
|
|
||
| const makefileBpfTemplate = ` |
There was a problem hiding this comment.
Biggest change in the diff: added the current libs master bpf Makefile as a template.
|
Note: tests are failing because of the flaky test fixed by df0c327 |
FedeDP
force-pushed
the
fix/bpf_build_new_libs
branch
from
8f8a761
to
7b068e7
Compare
|
Rebased on top of master to fix flaky test. |
|
/hold |
Signed-off-by: Federico Di Pierro <[email protected]>
…ld was requested. Signed-off-by: Federico Di Pierro <[email protected]>
FedeDP
force-pushed
the
fix/bpf_build_new_libs
branch
from
68bcf68
to
3fdcf8a
Compare
|
This will be only needed if falcosecurity/libs#1188 is merged. |
| var deps string | ||
| for _, l := range lines { | ||
| l = strings.TrimSpace(l) | ||
| if strings.HasPrefix(l, "set(BPF_SOURCES") { |
There was a problem hiding this comment.
Not ideal having to make this so code so tightly coupled to the contents of the CMakeLists.txt file, are there any other options for obtaining the deps sources list? Probably not, just wondering out loud =)
There was a problem hiding this comment.
Yep this code is really ugly :( it's so hard to deal with new and old versions, without breaking backward compatibility.
Btw for now this PR is on hold because it is only needed if falcosecurity/libs#1188 PR gets merged in libs :)
FedeDP
changed the title
|
This would be automatically fixed too in case we go with #302. |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh with Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with Provide feedback via https://github.com/falcosecurity/community. /lifecycle stale |
|
/remove-lifecycle stale |
|
Close because #302 was merged. |
|
@FedeDP: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area pkg
What this PR does / why we need it:
This adds support (in a backward compatible manner) to falcosecurity/libs#1188.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: