update(cmd): add builder image default and validator to root options

Signed-off-by: Luca Guerra <[email protected]>

cmd/root_options.go

@@ -2,8 +2,8 @@ package cmd
 
 import (
  "fmt"
-
  "github.com/creasty/defaults"
+ "github.com/falcosecurity/driverkit/pkg/driverbuilder"
  "github.com/falcosecurity/driverkit/pkg/driverbuilder/builder"
  "github.com/falcosecurity/driverkit/validate"
  "github.com/go-playground/validator/v10"
@@ -26,14 +26,20 @@ type RootOptions struct {
  KernelRelease string `validate:"required,ascii" name:"kernel release"`
  Target string `validate:"required,target" name:"target"`
  KernelConfigData string `validate:"omitempty,base64" name:"kernel config data"` // fixme > tag "name" does not seem to work when used at struct level, but works when used at inner level
- BuilderImage string `name:"builder image"`
+ BuilderImage string `validate:"imagename" name:"builder image"`
  Output OutputOptions
 }
 
 func init() {
  validate.V.RegisterStructValidation(RootOptionsLevelValidation, RootOptions{})
 }
 
+func (ro *RootOptions) SetDefaults() {
+ if defaults.CanUpdate(ro.BuilderImage) {
+ ro.BuilderImage = driverbuilder.BuilderBaseImage
+ }
+}
+
 // NewRootOptions ...
 func NewRootOptions() *RootOptions {
  rootOpts := &RootOptions{}
@@ -92,16 +98,16 @@ func (ro *RootOptions) toBuild() *builder.Build {
  }
 
  return &builder.Build{
- TargetType: builder.Type(ro.Target),
- DriverVersion: ro.DriverVersion,
- KernelVersion: ro.KernelVersion,
- KernelRelease: ro.KernelRelease,
- Architecture: ro.Architecture,
- KernelConfigData: kernelConfigData,
- ModuleFilePath: ro.Output.Module,
- ProbeFilePath: ro.Output.Probe,
- ModuleDriverName: ro.ModuleDriverName,
- ModuleDeviceName: ro.ModuleDeviceName,
+ TargetType:  builder.Type(ro.Target),
+ DriverVersion:  ro.DriverVersion,
+ KernelVersion:  ro.KernelVersion,
+ KernelRelease:  ro.KernelRelease,
+ Architecture:  ro.Architecture,
+ KernelConfigData:  kernelConfigData,
+ ModuleFilePath:  ro.Output.Module,
+ ProbeFilePath:  ro.Output.Probe,
+ ModuleDriverName:  ro.ModuleDriverName,
+ ModuleDeviceName:  ro.ModuleDeviceName,
  CustomBuilderImage: ro.BuilderImage,
  }
 }

validate/isimagename.go

@@ -0,0 +1,35 @@
+package validate
+
+import (
+ "github.com/go-playground/validator/v10"
+ "strings"
+)
+
+const letters = "abcdefghijklmnopqrstuvwxyz"
+const digits = "0123456789"
+const separators = "/.-@_:"
+const alphabet = letters + digits + separators
+
+func isImageName(fl validator.FieldLevel) bool {
+ name := fl.Field().String()
+
+ for _, c := range name {
+ if !strings.ContainsRune(alphabet, c) {
+ return false
+ }
+ }
+
+ for _, component := range strings.Split(name, "/") {
+ // a component may not be empty (i.e. double slashes are not allowed)
+ if len(component) == 0 {
+ return false
+ }
+
+ // a component may not start or end with a separator
+ if strings.Contains(separators, component[0:1]) || strings.Contains(separators, component[len(component)-1:]) {
+ return false
+ }
+ }
+
+ return true
+}

validate/validate.go

@@ -38,6 +38,7 @@ func init() {
  V.RegisterValidation("target", isTargetSupported)
  V.RegisterValidation("semver", isSemVer)
  V.RegisterValidation("proxy", isProxy)
+ V.RegisterValidation("imagename", isImageName)
 
  eng := en.New()
  uni := ut.New(eng, eng)