Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Brazilian Portuguese translations for Faker::Subscription #2960

Conversation

murichristopher
Copy link
Contributor

Motivation / Background

This Pull Request has been created to add new locale data for Brazilian Portuguese subscriptions.

Additional information

This update is based on existing English data and has been translated by native Brazilian Portuguese-speaking contributors.

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug, refactor something, or add a feature.
  • Tests and Rubocop are passing before submitting your proposed changes.

@stefannibrasil
Copy link
Contributor

HI @murichristopher thanks!

I tried this branch in the console bundle exec rake console and after setting the locale to pt-BR I still get some English results. Does that also happen for you? It seems to work for other locales, for example, es-MX.

@murichristopher
Copy link
Contributor Author

murichristopher commented Jun 11, 2024

Hey, @stefannibrasil,

There was a typo in the .yml locale file 😅. So I fixed it, and it appears to be working!

Here is the output that I have now in the console:

irb(main):001:0> Faker::Config.locale = 'pt-BR'
=> "pt-BR"
irb(main):002:0> Faker::Subscription.subscription_term
=> "Vitalícia"
irb(main):003:0> Faker::Subscription.plan
=> "Essential"
irb(main):004:0> Faker::Subscription.payment_term
=> "Anual"
irb(main):005:0> Faker::Subscription.plan
=> "Premium"
irb(main):006:0> Faker::Subscription.plan
=> "Gold"
irb(main):007:0> Faker::Subscription.plan
=> "Teste gratuito"
irb(main):008:0> 

lib/locales/pt-BR.yml Outdated Show resolved Hide resolved
lib/locales/pt-BR.yml Outdated Show resolved Hide resolved
@stefannibrasil
Copy link
Contributor

Hi @murichristopher are you still interested in moving this one forward? Thanks!

Copy link
Contributor

@stefannibrasil stefannibrasil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obrigada!

@stefannibrasil stefannibrasil merged commit 961cafd into faker-ruby:main Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants