Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate method order_column_definitions #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove duplicate method order_column_definitions #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions lib/activerecord-clean-db-structure/clean_dump.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,23 +180,6 @@ def primary_keys_cleanup
end
end
end

# Orders the columns definitions alphabetically
# - ignores quotes which surround column names that are equal to reserved PostgreSQL names.
# - keeps the columns at the top and places the constraints at the bottom.
def order_column_definitions
dump.gsub!(/^(?<table>CREATE TABLE .+?\(\n)(?<columns>.+?)(?=\n\);$)/m) do
columns =
$~[:columns]
.split(",\n")
.sort_by { |column| column[/[^ "]+/] }
.partition { |column| !column.match?(/\A *CONSTRAINT/) }
.flatten
.join(",\n")

[$~[:table], columns].join
end
end

# Moves the separate unique constraint statements to the create table statements.
def move_unique_constraints
Expand Down