Merge pull request hotosm#3208 from hotosm/fix/loops-compressed-in-tasks

loop compressed and array initialized

backend/models/dtos/project_dto.py

@@ -400,6 +400,11 @@ def __init__(self):
 class LockedTasksForUser(Model):
     """ Describes all tasks locked by an individual user"""
 
+    def __init__(self):
+        """ DTO constructor initialise all arrays to empty"""
+        super().__init__()
+        self.locked_tasks = []
+
     locked_tasks = ListType(IntType, serialized_name="lockedTasks")
     project = IntType(serialized_name="projectId")
     task_status = StringType(serialized_name="taskStatus")

backend/models/postgis/task.py

@@ -851,8 +851,7 @@ def get_tasks_as_geojson_feature_collection(
             if not tasks or len(tasks) == 0:
                 raise NotFound()
             else:
-                for task in tasks:
-                    tasks_filters.append(task.id)
+                tasks_filters = [task.id for task in tasks]
             filters = [Task.project_id == project_id, Task.id.in_(tasks_filters)]
         else:
             tasks = Task.get_all_tasks(project_id)
@@ -1105,7 +1104,6 @@ def get_locked_tasks_for_user(user_id: int):
         """ Gets tasks on project owned by specified user id"""
         tasks = Task.query.filter_by(locked_by=user_id)
         tasks_dto = LockedTasksForUser()
-        tasks_dto.locked_tasks = []
         for task in tasks:
             tasks_dto.locked_tasks.append(task.id)
             tasks_dto.project = task.project_id
@@ -1116,9 +1114,6 @@ def get_locked_tasks_for_user(user_id: int):
     def get_locked_tasks_details_for_user(user_id: int):
         """ Gets tasks on project owned by specified user id"""
         tasks = Task.query.filter_by(locked_by=user_id)
-
-        locked_tasks = []
-        for task in tasks:
-            locked_tasks.append(task)
+        locked_tasks = [task for task in tasks]
 
         return locked_tasks