Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(permissions): add default country and update URL #695

Merged
merged 1 commit into from
Nov 10, 2024
Merged

feat(permissions): add default country and update URL #695

merged 1 commit into from
Nov 10, 2024

Conversation

Cristianoying
Copy link
Contributor

@Cristianoying Cristianoying commented Oct 16, 2024 •
edited
Loading

Fix the situation that permissions cannot be queried without a country code in some cases.

  • Add default country ('us') if not provided in opts
  • Update batchexecute URL to include country (gl) parameter

@facundoolano
Copy link
Owner

what's up with this one, is it ready to merge? (I see it's still in draft)

@Cristianoying Cristianoying marked this pull request as ready for review November 9, 2024 05:36
@Cristianoying
Copy link
Contributor Author

I was thinking of adding some test code but I've been so busy forgot to add it.😂 but I've tested it in my production environment.

@facundoolano facundoolano merged commit 6a4e17d into facundoolano:main Nov 10, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cristianoying @facundoolano