Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix variable number of reviews returned #676 #677

Merged
merged 5 commits into from
Apr 9, 2024

Commits on Apr 7, 2024

  1. implement cookieJar support

    fixes issue facundoolano#676
    Peeter Marvet committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    c1cf82b View commit details
    Browse the repository at this point in the history
  2. minor codestyling

    Peeter Marvet committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    ee29fb0 View commit details
    Browse the repository at this point in the history
  3. more codestyling to pass lint

    Peeter Marvet committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    fa21f94 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4e110ef View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. add test for equal results (amend PR facundoolano#677)

    For detection of facundoolano#676 (less than actual number of requests returned, different response count on each request).
    
    Using app with large number of reviews sorted by helpfulness (assuming this set does not change as frequently as just reviews), num: 1500 is reasonably fast and we get 2 x 10 paged requests (of 150 results) that ought to prove paging works.
    Peeter Marvet committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    4461113 View commit details
    Browse the repository at this point in the history