Add a working example of the layout #698
Open
+263
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔍 Visual review for your branch is published 🔍Here are the links to: |
|
Is it me, or the bottom padding for each category when collapsed is to large? |
|
Amazing work! Since you'll be off for a week or two, I'll add a few commits with some improvement I think could be made before merging :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a working example of the layout, with the show/hide sidebar functionality and the rest of the layout adapting to it.
Screen.Recording.2024-10-15.at.18.11.42.mov
Note: The layout isn't entirely finished as it lacks a few things and has a few bugs, but it's enough to try out. I'll keep working on it when I'm back! 👀🪛
Things to be improved:
useMediaQueryhook in some places, but I'd like to investigate if I can avoid it in some places (probably yes!).