Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/fct 16897/new tab layout #360
Feat/fct 16897/new tab layout #360
Changes from 17 commits
031b4c4
ba8a19b
c8f0eed
b2203e1
4aefb66
12c49f0
9dfe1d9
769a084
2117599
ff0f96e
cd0d9c9
2732934
076d576
8ca554c
5f25cea
4b55ff8
b156d3b
eda1851
4580dcf
0003d08
5b37fc8
be38faa
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 39 in src/playground/Pages/Tabs/index.stories.tsx
GitHub Actions / test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would you feel about calling this whole story
EmployeeProfile
to make it more explicit?Tabs
looks too generic to me.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was aiming for generic, my reasoning was that the same layout could be reused in a different screen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand! The thing is that this would make sense once we promote this to a component. Then we can find a meaningful name. If it lives in the playground, I think it's probably better to put it a very explicit name just to convey that's an "example".
I mean obviously not a blocker!