Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for sigquit #9

Merged
merged 9 commits into from
Aug 23, 2023
Merged

Conversation

gabr1c0m
Copy link
Contributor

No description provided.

@gabr1c0m gabr1c0m closed this Aug 23, 2023
@gabr1c0m gabr1c0m reopened this Aug 23, 2023
@gabr1c0m gabr1c0m closed this Aug 23, 2023
@gabr1c0m gabr1c0m reopened this Aug 23, 2023
@gabr1c0m gabr1c0m closed this Aug 23, 2023
@gabr1c0m gabr1c0m reopened this Aug 23, 2023
Copy link
Member

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from a small nitpick, LGTM! Could you also add a changelog entry, with a link to where it's explained that SIGQUIT is used in PHP's Alpine Docker images?

tests/E2E/TerminateCommandTest.php Outdated Show resolved Hide resolved
Gabriele 'gabricom' Colombera added 2 commits August 23, 2023 16:12
@gabr1c0m gabr1c0m requested a review from Jean85 August 23, 2023 14:19
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Alessandro Lai <[email protected]>
Copy link
Member

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@Jean85 Jean85 merged commit 0095f18 into facile-it:1.x Aug 23, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants