fix: replace abandoned packages #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p4veI
commented
Jun 13, 2024
| $this->algorithmManager, | ||
| new CompressionMethodManager([new Deflate()]) | ||
| ); | ||
| $this->jweBuilder = $jweBuilder ?? new JWEBuilder($this->algorithmManager); |
There was a problem hiding this comment.
|
Anything I can do to help this one along? Abandoned packages in our project are making people feel antsy. |
|
@cooperaj I think in order to finish this, we need https://github.com/facile-it/php-jose-verifier v0.5 to be completed.. |
cooperaj
reviewed
Jul 10, 2024
| @@ -46,7 +46,7 @@ public function build(string $resource): IssuerInterface | |||
| $metadata = IssuerMetadata::fromArray($metadataBuilder->build()->fetch($resource)); | |||
|
|
|||
| $jwksProviderBuilder = $this->buildJwksProviderBuilder(); | |||
| $jwksProviderBuilder->setJwksUri($metadata->getJwksUri()); | |||
| $jwksProviderBuilder->withJwksUri($metadata->getJwksUri()); | |||
There was a problem hiding this comment.
I think this is a fluent method call so potentially this will want to be
Suggested change
| $jwksProviderBuilder->withJwksUri($metadata->getJwksUri()); | |
| $jwksProviderBuilder = ($this->buildJwksProviderBuilder())->withJwksUri($metadata->getJwksUri()); |
|
Looks like there's new beta release on https://github.com/facile-it/php-jose-verifier |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, we're using this package in one of our project and came around this issue with abandoned packages, it's forcing us to add indirect dependency to our project. I noticed somebody has already tried to fix this issue in #37 but seems like unresolved change requests are blocking the release, hope this could help.
thanks!
EDIT: looks like I can't really finish this either 😅