Fall back to default config for trailing_comma_in_multiline
#72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is thanks to PHP-CS-Fixer/PHP-CS-Fixer#7916 that adds `trailing_comma_in_multiline` to the PER-CS-2.0 ruleset
Jean85
force-pushed
the
arguments-trailing-commas
branch
from
ba44cbe
to
5e1a464
Compare
… included in PER-CS)
|
After df282ad CI starts failing under PHP 7.4 since the trailing argument comma requires PHP 8.0. We may need to postpone this PR to when we will abandon support for PHP 7.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is thanks to PHP-CS-Fixer/PHP-CS-Fixer#7916 that adds
trailing_comma_in_multilineto the PER-CS-2.0 ruleset.This should fix the CI: https://github.com/facile-it/facile-coding-standard/actions/runs/8683344265/job/23816753810