-
Notifications
You must be signed in to change notification settings - Fork 333
Add resisc45 and update eurosat datasets #464
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @normster !
That's an excellent contributions to VISSL, a very important dataset to have in the VISSL library.
I wrote a few comments as potential improvement, but it's great work overall.
Thanks again :)
Adding a few ideas that could be done inside this PR or in a different one:
Feel free to complete this one if you want to tackle those or else we can manage it on our side afterwards. |
@prigoyal has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
@normster has updated the pull request. You must reimport the pull request before landing. |
@prigoyal has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Hi @normster! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Hi @QuentinDuval,
I implemented the RESISC45 dataset script and added random sampling to the eurosat dataset. OpenAI shared some details about these two datasets here but the 10% train split for RESISC45 is very small, so I just used the VTAB percentages, combining train + val into train.
Norman