Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

Add resisc45 and update eurosat datasets #464

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

normster
Copy link

@normster normster commented Nov 1, 2021

Hi @QuentinDuval,

I implemented the RESISC45 dataset script and added random sampling to the eurosat dataset. OpenAI shared some details about these two datasets here but the 10% train split for RESISC45 is very small, so I just used the VTAB percentages, combining train + val into train.

Norman

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 1, 2021
Copy link
Contributor

@QuentinDuval QuentinDuval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @normster !

That's an excellent contributions to VISSL, a very important dataset to have in the VISSL library.

I wrote a few comments as potential improvement, but it's great work overall.

Thanks again :)

extra_scripts/datasets/create_euro_sat_data_files.py Outdated Show resolved Hide resolved
extra_scripts/datasets/create_euro_sat_data_files.py Outdated Show resolved Hide resolved
extra_scripts/datasets/create_resisc45_data_files.py Outdated Show resolved Hide resolved
extra_scripts/datasets/create_resisc45_data_files.py Outdated Show resolved Hide resolved
@QuentinDuval
Copy link
Contributor

Adding a few ideas that could be done inside this PR or in a different one:

  • completing the dataset_catalog.json to have an (empty) entry for the dataset
  • adding configuration files in the linear evaluation benchmarks folder to run a benchmark on this dataset

Feel free to complete this one if you want to tackle those or else we can manage it on our side afterwards.

@facebook-github-bot
Copy link
Contributor

@prigoyal has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@normster has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@prigoyal has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

Hi @normster!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants