Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

Tests for NLE when using two environments sequentially or in threads #253

Merged
merged 5 commits into from
Sep 24, 2021

Conversation

heiner
Copy link
Contributor

@heiner heiner commented Sep 20, 2021

And misc. changes.

Turns out #254 only shows up on my local machine (?!).

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 20, 2021
@heiner heiner marked this pull request as ready for review September 21, 2021 09:35
@heiner heiner changed the title Test that shows a crash in NLE when using two environments sequentially. Tests for NLE when using two environments sequentially or in threads Sep 21, 2021
@heiner
Copy link
Contributor Author

heiner commented Sep 21, 2021

The second test here shows that an approach like https://gist.github.com/heiner/67955538cce6375dbdd6fa97ffd11ce9 can work. In my tests, this could make SPS for tasks with very short episodes up to 50% faster.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants