Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align to gym>0.26 interface #99

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

epignatelli
Copy link

@epignatelli epignatelli commented Jan 15, 2024

Associated issue: #98

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you lint your code locally prior to submission?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Closing issues

Closes #98

@facebook-github-bot
Copy link

Hi @epignatelli!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@github-actions github-actions bot added core envs Contributions to MiniHack environments labels Jan 15, 2024
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 15, 2024
@epignatelli epignatelli marked this pull request as draft January 15, 2024 19:40
@github-actions github-actions bot added the tests Contributions to our tests. label Jan 19, 2024

def reset(self, wizkit_items=None):
obs = self.env.reset(wizkit_items=wizkit_items)
def reset(self, seed=None, options={}):
Copy link
Author

@epignatelli epignatelli Apr 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

options={} is actually dangerous here and everywhere else it repeats.

Suggested change
def reset(self, seed=None, options={}):
def reset(self, seed=None, options=None):

would be better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. core envs Contributions to MiniHack environments tests Contributions to our tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Align to gym>=0.26 API
2 participants