Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gloo] reenable libuv build (2/N) #396

Closed
wants to merge 7 commits into from
Closed

[gloo] reenable libuv build (2/N) #396

wants to merge 7 commits into from

Conversation

c-p-i-o
Copy link
Contributor

@c-p-i-o c-p-i-o commented Nov 18, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

Summary:
As part of reviving CI, reenable libuv builds - but disable it for the windows build for now until we can figure out linker errors.

Test Plan:
Test on github.

Reviewers:

Subscribers:

Tasks:

Tags:

@c-p-i-o
[gloo] reenable libuv build (2/N)
1427d34 
Summary:
As part of reviving CI, reenable libuv that is causing CI errors.

Test Plan:
Test on github.

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@c-p-i-o c-p-i-o mentioned this pull request Nov 18, 2024
Closed
c-p-i-o added a commit that referenced this pull request Nov 18, 2024
@c-p-i-o
[gloo] reenable libuv build (2/N)
6cc8b06 
Summary:
As part of reviving CI, reenable libuv that is causing CI errors.

Test Plan:
Test on github.

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 11b29816c437751996085033269cef5e005775b3
Pull Request resolved: #396
@c-p-i-o
Update on "[gloo] reenable libuv build (2/N)"
29ef415 
Summary:
As part of reviving CI, reenable libuv that is causing CI errors.

Test Plan:
Test on github.

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
c-p-i-o added a commit that referenced this pull request Nov 18, 2024
@c-p-i-o
[gloo] reenable libuv build (2/N)
c97071d 
Summary:
As part of reviving CI, reenable libuv that is causing CI errors.

Test Plan:
Test on github.

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: a6934ab5c30e55816477e00a3cfe4e8926adbbcf
Pull Request resolved: #396
@c-p-i-o
Update on "[gloo] reenable libuv build (2/N)"
bae994a 
Summary:
As part of reviving CI, reenable libuv that is causing CI errors.

Test Plan:
Test on github.

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
c-p-i-o added a commit that referenced this pull request Nov 25, 2024
@c-p-i-o
[gloo] reenable libuv build (2/N)
f342e5d 
Summary:
As part of reviving CI, reenable libuv that is causing CI errors.

Test Plan:
Test on github.

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 23edd87642742703696b5c8ed290a094a8624170
Pull Request resolved: #396
@c-p-i-o
Update on "[gloo] reenable libuv build (2/N)"
d10b4b3 
Summary:
As part of reviving CI, reenable libuv that is causing CI errors.

Test Plan:
Test on github.

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
c-p-i-o added a commit that referenced this pull request Nov 26, 2024
@c-p-i-o
[gloo] reenable libuv build (2/N)
171afa1 
Summary:
As part of reviving CI, reenable libuv that is causing CI errors.

Test Plan:
Test on github.

ghstack-source-id: 73f01769ba3c9bbece7b6ffe1299c3dc6aefe814
Pull Request resolved: #396
@c-p-i-o
Update on "[gloo] reenable libuv build (2/N)"
967e418 
Summary:
As part of reviving CI, reenable libuv builds - but disable it for the windows build for now until we can figure out linker errors.

Test Plan:
Test on github.

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
c-p-i-o added a commit that referenced this pull request Nov 26, 2024
@c-p-i-o
[gloo] reenable libuv build (2/N)
f58fccb 
Summary:
As part of reviving CI, reenable libuv that is causing CI errors.

Test Plan:
Test on github.

ghstack-source-id: 4a7ca33ef98640a449e65510a61393f506604046
Pull Request resolved: #396
@c-p-i-o
Update on "[gloo] reenable libuv build (2/N)"
8d5b86d 
Summary:
As part of reviving CI, reenable libuv builds - but disable it for the windows build for now until we can figure out linker errors.

Test Plan:
Test on github.

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
c-p-i-o added a commit that referenced this pull request Nov 26, 2024
@c-p-i-o
[gloo] reenable libuv build (2/N)
b9655b3 
Summary:
As part of reviving CI, reenable libuv that is causing CI errors.

Test Plan:
Test on github.

ghstack-source-id: 734bfddda6a4d88374ab0eab97c396441f83abb3
Pull Request resolved: #396
@c-p-i-o
Update on "[gloo] reenable libuv build (2/N)"
94b7c1b 
Summary:
As part of reviving CI, reenable libuv builds - but disable it for the windows build for now until we can figure out linker errors.

Test Plan:
Test on github.

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
c-p-i-o added a commit that referenced this pull request Nov 26, 2024
@c-p-i-o
[gloo] reenable libuv build (2/N)
f944f46 
Summary:
As part of reviving CI, reenable libuv - but leave it disabled for
MSBUILD - until we can figure out linker errors.

Test Plan:
Test on github.

ghstack-source-id: a69c363f2693e69b7a8dfb14764c0d95736efabc
Pull Request resolved: #396
@c-p-i-o c-p-i-o self-assigned this Nov 26, 2024
@c-p-i-o c-p-i-o requested review from d4l3k and fduwjj November 26, 2024 22:47
d4l3k
d4l3k approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@d4l3k d4l3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@c-p-i-o c-p-i-o mentioned this pull request Nov 26, 2024
Merged
@c-p-i-o c-p-i-o closed this Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d4l3k d4l3k d4l3k approved these changes

@fduwjj fduwjj Awaiting requested review from fduwjj

Assignees

@c-p-i-o c-p-i-o

Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@c-p-i-o @d4l3k @facebook-github-bot