Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate circeci to github actions #392

Closed
wants to merge 3 commits into from
Closed

migrate circeci to github actions #392

wants to merge 3 commits into from

Conversation

c-p-i-o
Copy link
Contributor

@c-p-i-o c-p-i-o commented Oct 14, 2024 •
edited
Loading

Summary:
Migrate circleci to github actions.
circleci has been removed from gloo and the goal here is to revive CI but use github instead.
In this change:

  1. Put back win.cc and win.h that were erroneously deleted.
  2. Comment out uv build as this breaks CI because of errors for now. I will address these in a follow-on diff.
  3. Add a build.yaml to do a windows build.

Test Plan:
Test on github passes.

Reviewers:

Subscribers:

Tasks:

Tags:

@c-p-i-o c-p-i-o self-assigned this Oct 14, 2024
@c-p-i-o c-p-i-o force-pushed the cpio/migrate_circleci branch 27 times, most recently from 911e830 to 3ffb3a0 Compare October 30, 2024 00:11
@c-p-i-o
migrate circeci to github actions + fixes
c9af35b 
Summary:
1. Migrate circleci to github actions.
2. Remove reference to win.cc and win.h.
3. Remove deleted test tls_tcp_test.cc
4. Remove left behind CMakeLists.txt file in libuv directory.

Test Plan:
Test on github.
@c-p-i-o c-p-i-o force-pushed the cpio/migrate_circleci branch 5 times, most recently from c258b2d to 09f8c3d Compare November 8, 2024 17:56
@c-p-i-o
Revert "fbcode/gloo/common"
f2a6125 
This reverts commit 8014f79.
@c-p-i-o
Disable libuv in tests
8bb5cee 
Summary:
Disable libuv in tests until CI is green again.

Test Plan:
Test on github
@c-p-i-o c-p-i-o closed this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@c-p-i-o c-p-i-o

Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c-p-i-o @facebook-github-bot