Skip to content

Commit

Permalink
Fix shadowed variable in fizz/tool/FizzCommandCommon.cpp
Browse files Browse the repository at this point in the history
Summary:
Our upcoming compiler upgrade will require us not to have shadowed variables. Such variables have a _high_ bug rate and reduce readability, so we would like to avoid them even if the compiler was not forcing us to do so.

This codemod attempts to fix an instance of a shadowed variable. Please review with care: if it's failed the result will be a silent bug.

**What's a shadowed variable?**

Shadowed variables are variables in an inner scope with the same name as another variable in an outer scope. Having the same name for both variables might be semantically correct, but it can make the code confusing to read! It can also hide subtle bugs.

This diff fixes such an issue by renaming the variable.

 - If you approve of this diff, please use the "Accept & Ship" button :-)

Reviewed By: knekritz

Differential Revision: D53478925

fbshipit-source-id: 4b8dbab0157e668b33c4364ede2212d2d456011d
  • Loading branch information
r-barnes authored and facebook-github-bot committed Feb 7, 2024
1 parent 5c65dfa commit b46065f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fizz/tool/FizzCommandCommon.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ void TerminalInputHandler::handlerReady(uint16_t events) noexcept {
}

void TerminalInputHandler::hitEOF() {
evb_->runInLoop([cb_ = cb_]() { cb_->close(); });
evb_->runInLoop([cb = cb_]() { cb->close(); });
}

std::vector<Extension> getExtensions(folly::StringPiece hex) {
Expand Down

0 comments on commit b46065f

Please sign in to comment.