Skip to content

Commit

Permalink
Fix compiler warning issues in fizz/server/ServerProtocol.cpp
Browse files Browse the repository at this point in the history
Summary:
This diff fixes issues identified by one or more of these compiler warning flags:
* `-Wpessimizing-move`
* `-Wmissing-braces `
* `-Wself-assign`
* `-Wunused-lambda-capture `
* `-Wheader-hygiene`
* `-Wunused-variable`
* `-Wunused-parameter`
* `-Wsign-compare`

If the code compiles, it should work.

Reviewed By: dmm-fb

Differential Revision: D52970480

fbshipit-source-id: 172f2cfb79af4018444d379937682d9cbbfc402e
  • Loading branch information
r-barnes authored and facebook-github-bot committed Jan 23, 2024
1 parent 7218521 commit a2ef36b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions fizz/server/ServerProtocol.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -690,7 +690,7 @@ static void validateGroups(const std::vector<KeyShareEntry>& client_shares) {
}

static std::tuple<NamedGroup, Optional<Buf>> negotiateGroup(
ProtocolVersion version,
ProtocolVersion /*version*/,
const ClientHello& chlo,
const std::vector<NamedGroup>& supportedGroups) {
auto groups = getExtension<SupportedGroups>(chlo.extensions);
Expand Down Expand Up @@ -747,7 +747,7 @@ static HelloRetryRequest getHelloRetryRequest(
CipherSuite cipher,
NamedGroup group,
Buf legacySessionId,
HandshakeContext& handshakeContext) {
HandshakeContext& /*handshakeContext*/) {
HelloRetryRequest hrr;
hrr.legacy_version = ProtocolVersion::tls_1_2;
hrr.legacy_session_id_echo = std::move(legacySessionId);
Expand Down

0 comments on commit a2ef36b

Please sign in to comment.