Update expect action for clarity #504
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The console output displayed when using `expect` action was cumbersome and a little difficult to interpret. Expect function by itself, is good enough to display the input and output succintly. It seemed like having additional logging made it redundant and unclear to interpret. Cleaning up the logging so that output from `expect` action is easy to read. Differential Revision: D60419102
w51d
requested review from
d3sch41n,
cedowens,
d0n601 and
CrimsonK1ng
as code owners
|
This pull request was exported from Phabricator. Differential Revision: D60419102 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The console output displayed when using
expectaction was cumbersome and a little difficult to interpret.Expect function by itself, is good enough to display the input and output succintly.
It seemed like having additional logging made it redundant and unclear to interpret.
Cleaning up the logging so that output from
expectaction is easy to read.Differential Revision: D60419102