Skip to content
This repository has been archived by the owner on May 1, 2023. It is now read-only.

Commit

Permalink
Fix assorted C++ nits caught by stricter warnings from clang-5.0
Browse files Browse the repository at this point in the history
Summary: Offload the gcc-compatible fixes from the diff that cuts-over to building fb4a with clang.

Differential Revision: D6525454

fbshipit-source-id: 02ce4d8f84ebbce6a4605f0b64b822e11defe20a
  • Loading branch information
gkmhub authored and facebook-github-bot committed Dec 9, 2017
1 parent 5276081 commit f1edf45
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions cpp/profiler/BaseTracer.h
Original file line number Diff line number Diff line change
Expand Up @@ -27,17 +27,17 @@ class BaseTracer {
ucontext_t* ucontext,
int64_t* frames,
uint8_t& depth,
uint8_t max_depth);
uint8_t max_depth) = 0;

virtual void flushStack(
int64_t* frames,
uint8_t depth,
int tid,
int64_t time_);
int64_t time_) = 0;

virtual void startTracing();
virtual void startTracing() = 0;

virtual void stopTracing();
virtual void stopTracing() = 0;
};

} // namespace profiler
Expand Down

0 comments on commit f1edf45

Please sign in to comment.