Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Re-land typed descriptors and printer #2511

Closed
wants to merge 8 commits into from
Closed

Re-land typed descriptors and printer #2511

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1b06bce
Reland typed descriptors and printer
sebmarkbage Aug 30, 2018
922d40c
Fix TextPrinter by exposing assumed path conditions
sebmarkbage Aug 30, 2018
2b4546d
Use undefined instead of missing to represent absent field in descrip…
sebmarkbage Aug 30, 2018
f046958
Fix conflict with master
trueadm Aug 31, 2018
2e140d9
Fix more conflicts
trueadm Aug 31, 2018
3a4d866
fix conflict
trueadm Aug 31, 2018
b5c8a1d
Fixed error with identical checks now that properties exist, for in w…
trueadm Aug 31, 2018
5d8caf2
Fixed flow issues
trueadm Aug 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/methods/properties.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -936,6 +936,9 @@ export class PropertiesImplementation {
// same value as the corresponding field in current when compared using the SameValue algorithm.
let identical = true;
for (let field in Desc) {
if (Desc[field] === undefined) {
continue;
}
if ((current: any)[field] === undefined) {
identical = false;
} else {
Expand Down Expand Up @@ -1003,8 +1006,8 @@ export class PropertiesImplementation {
// Preserve the existing values of the converted property's [[Configurable]] and [[Enumerable]] attributes and set the rest of the property's attributes to their default values.
if (O !== undefined) {
invariant(P !== undefined);
delete current.writable;
delete current.value;
current.writable = undefined;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! I didn't think to search for delete.

current.value = undefined;
current.get = realm.intrinsics.undefined;
current.set = realm.intrinsics.undefined;
}
Expand All @@ -1013,8 +1016,8 @@ export class PropertiesImplementation {
// i. If O is not undefined, convert the property named P of object O from an accessor property to a data property. Preserve the existing values of the converted property's [[Configurable]] and [[Enumerable]] attributes and set the rest of the property's attributes to their default values.
if (O !== undefined) {
invariant(P !== undefined);
delete current.get;
delete current.set;
current.get = undefined;
current.set = undefined;
current.writable = false;
current.value = realm.intrinsics.undefined;
}
Expand Down