Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

Added mapillary overlay to task selection map #280

Open
wants to merge 26 commits into
base: develop
Choose a base branch
from

Conversation

ezzhang8
Copy link
Contributor

@ezzhang8 ezzhang8 commented Aug 4, 2022

No description provided.

- Date picker added to imagery page in settings
- Database migrated with new column for the date
2 new trim toggles + image capture on legend
- Mapillary photo overlay now open by default in iD editor

- fromDate filter set from project settings in iD editor
- Added image capture mode toggle
- Settings related to image capture mode only appear if this toggle is enabled
- Added all connected UI prompts to messages
- "Earliest imagery capture date" shortened to "After:" positioned before date picker
- Added mapillary organization id filter input
added earliestStreetImagery as a dependency, wrapped filter in if statement
Updates DTOs to make the new project settings persistent
Now updates based on whether user selects image capture mode
Now only enables mapillary and date filter by default if image capture mode is enabled
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 4, 2022
@zlavergne
Copy link
Contributor

zlavergne commented Aug 8, 2022

@ezzhang8 can you rebase this PR onto your other one please. There is a bunch of duplicate changes and rebasing will save me a time and make sure I don't make duplicate comments

@ezzhang8
Copy link
Contributor Author

ezzhang8 commented Aug 8, 2022

@ezzhang8 can you rebase this PR onto your other one please. There is a bunch of duplicate changes and rebasing will save me a time and make sure I don't make duplicate comments

@zlavergne Rebased this branch onto the other PR :)

Copy link
Contributor

@zlavergne zlavergne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main thing is regarding using an already built switch component for the Mapillary layers and hooking it up with a state.

frontend/src/components/projectEdit/imageryForm.js Outdated Show resolved Hide resolved
frontend/src/components/taskSelection/footer.js Outdated Show resolved Hide resolved
frontend/src/components/taskSelection/map.js Outdated Show resolved Hide resolved
frontend/src/components/taskSelection/map.js Outdated Show resolved Hide resolved
frontend/src/components/taskSelection/map.js Outdated Show resolved Hide resolved
frontend/src/components/taskSelection/map.js Outdated Show resolved Hide resolved
frontend/src/components/taskSelection/map.js Outdated Show resolved Hide resolved
@ezzhang8
Copy link
Contributor Author

@zlavergne Addressed all the comments. Let me know if there something I missed!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Component: Backend Component: Frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants