Merge pull request #4115 from Adenilson/leak01

[zstd][leak] Avoid memory leak on early return of ZSTD_generateSequence
facebook · Aug 9, 2024 · 1eb32ff · 1eb32ff
2 parents ee1fc7e + a40bad8
commit 1eb32ff
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/lib/compress/zstd_compress.c b/lib/compress/zstd_compress.c
@@ -3458,7 +3458,7 @@ size_t ZSTD_generateSequences(ZSTD_CCtx* zc, ZSTD_Sequence* outSeqs,
  size_t outSeqsSize, const void* src, size_t srcSize)
 {
  const size_t dstCapacity = ZSTD_compressBound(srcSize);
- void* dst = ZSTD_customMalloc(dstCapacity, ZSTD_defaultCMem);
+ void* dst; /* Make C90 happy. */
  SeqCollector seqCollector;
  {
  int targetCBlockSize;
@@ -3471,6 +3471,7 @@ size_t ZSTD_generateSequences(ZSTD_CCtx* zc, ZSTD_Sequence* outSeqs,
  RETURN_ERROR_IF(nbWorkers != 0, parameter_unsupported, "nbWorkers != 0");
  }
 
+ dst = ZSTD_customMalloc(dstCapacity, ZSTD_defaultCMem);
  RETURN_ERROR_IF(dst == NULL, memory_allocation, "NULL pointer!");
 
  seqCollector.collectSequences = 1;