Transfer current layout before calling baseline function #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woehrl01
force-pushed
the
baseline_transfer
branch
from
e71eb4e
to
8cb6c1a
Compare
|
Seems legit! Thanks! |
There was a problem hiding this comment.
@emilsjolander is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
YogaNodeTest.java:testBaseline is failing after this. could you have a look when you have the time? |
woehrl01
force-pushed
the
baseline_transfer
branch
2 times, most recently
from
c981db0
to
bfe53b1
Compare
do not reset newLayoutFlag on baseline transfer fixed bad method call fix reference
woehrl01
force-pushed
the
baseline_transfer
branch
from
bfe53b1
to
2a3d9ba
Compare
|
@emilsjolander, nearly missed this open PR. I updated the code, and it should now pass the test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative fix for #616. This transfers the current layout to the java side before calling the custom baseline function.