Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align order of params between calculateLayoutInternal and calculateLayoutImpl #1755

Closed
wants to merge 2 commits into from
Closed

Align order of params between calculateLayoutInternal and calculateLayoutImpl #1755

wants to merge 2 commits into from

Commits on Nov 26, 2024

  1. Camel case LengthValue in Node.cpp (facebook#1754) 

    Summary:
X-link: facebook/react-native#47971


This was annoying me

Changelog: [Internal]

Reviewed By: NickGerleman

Differential Revision: D66510734
    @joevilches @facebook-github-bot
    joevilches authored and facebook-github-bot committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    8f841b1 View commit details
    Browse the repository at this point in the history

  2. Align order of params between calculateLayoutInternal and calculateLa… 

    …youtImpl

Summary:
I've been working with callsites here and its annoying if you switch these that you need to move these params around too. Let's just make them the same order

Changelog: [Internal]

Differential Revision: D66519836
    @joevilches @facebook-github-bot
    joevilches authored and facebook-github-bot committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    eda343a View commit details
    Browse the repository at this point in the history