Back out "Modify private apis to set, store, and get intrinsic sizing keywords" #1750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request was exported from Phabricator. Differential Revision: D66332307 |
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Nov 21, 2024
… keywords" Summary: X-link: facebook/yoga#1750 These APIs were only added so that we could do TDD as we work on intrinsic sizing functionality. As of right now they do nothing. We are aiming on publishing a new version of Yoga soon so for the time being we are going to back these out so as not to confuse anyone with this new functionality. Ideally we get to a point where we have some temporary experimental header to stage these in but this is a bit time sensitive so just backing out for now Changelog: [Internal] Differential Revision: D66332307
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Nov 21, 2024
… keywords" (facebook#47895) Summary: X-link: facebook/yoga#1750 These APIs were only added so that we could do TDD as we work on intrinsic sizing functionality. As of right now they do nothing. We are aiming on publishing a new version of Yoga soon so for the time being we are going to back these out so as not to confuse anyone with this new functionality. Ideally we get to a point where we have some temporary experimental header to stage these in but this is a bit time sensitive so just backing out for now Changelog: [Internal] Differential Revision: D66332307
|
This pull request was exported from Phabricator. Differential Revision: D66332307 |
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Nov 21, 2024
… keywords" (facebook#1750) Summary: X-link: facebook/react-native#47895 Pull Request resolved: facebook#1750 These APIs were only added so that we could do TDD as we work on intrinsic sizing functionality. As of right now they do nothing. We are aiming on publishing a new version of Yoga soon so for the time being we are going to back these out so as not to confuse anyone with this new functionality. Ideally we get to a point where we have some temporary experimental header to stage these in but this is a bit time sensitive so just backing out for now Changelog: [Internal] Differential Revision: D66332307
joevilches
force-pushed
the
export-D66332307
branch
from
4bf8f9d
to
c116ca9
Compare
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Nov 21, 2024
… keywords" (facebook#47895) Summary: X-link: facebook/yoga#1750 These APIs were only added so that we could do TDD as we work on intrinsic sizing functionality. As of right now they do nothing. We are aiming on publishing a new version of Yoga soon so for the time being we are going to back these out so as not to confuse anyone with this new functionality. Ideally we get to a point where we have some temporary experimental header to stage these in but this is a bit time sensitive so just backing out for now Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D66332307
|
This pull request was exported from Phabricator. Differential Revision: D66332307 |
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Nov 22, 2024
… keywords" (facebook#1750) Summary: X-link: facebook/react-native#47895 Pull Request resolved: facebook#1750 These APIs were only added so that we could do TDD as we work on intrinsic sizing functionality. As of right now they do nothing. We are aiming on publishing a new version of Yoga soon so for the time being we are going to back these out so as not to confuse anyone with this new functionality. Ideally we get to a point where we have some temporary experimental header to stage these in but this is a bit time sensitive so just backing out for now Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D66332307
joevilches
force-pushed
the
export-D66332307
branch
from
c116ca9
to
5e43a93
Compare
Summary: Original commit changeset: 1e3e7214fab0 Original Phabricator Diff: D64145117 Differential Revision: D66332308
Summary: Original commit changeset: f15fae9fc010 Original Phabricator Diff: D64002837 Differential Revision: D66332309
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Nov 25, 2024
… keywords" (facebook#47895) Summary: X-link: facebook/yoga#1750 These APIs were only added so that we could do TDD as we work on intrinsic sizing functionality. As of right now they do nothing. We are aiming on publishing a new version of Yoga soon so for the time being we are going to back these out so as not to confuse anyone with this new functionality. Ideally we get to a point where we have some temporary experimental header to stage these in but this is a bit time sensitive so just backing out for now Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D66332307
… keywords" (facebook#1750) Summary: X-link: facebook/react-native#47895 Pull Request resolved: facebook#1750 These APIs were only added so that we could do TDD as we work on intrinsic sizing functionality. As of right now they do nothing. We are aiming on publishing a new version of Yoga soon so for the time being we are going to back these out so as not to confuse anyone with this new functionality. Ideally we get to a point where we have some temporary experimental header to stage these in but this is a bit time sensitive so just backing out for now Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D66332307
|
This pull request was exported from Phabricator. Differential Revision: D66332307 |
joevilches
force-pushed
the
export-D66332307
branch
from
5e43a93
to
b59b83c
Compare
|
This pull request has been merged in be00354. |
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Nov 25, 2024
… keywords" (#47895) Summary: Pull Request resolved: #47895 X-link: facebook/yoga#1750 These APIs were only added so that we could do TDD as we work on intrinsic sizing functionality. As of right now they do nothing. We are aiming on publishing a new version of Yoga soon so for the time being we are going to back these out so as not to confuse anyone with this new functionality. Ideally we get to a point where we have some temporary experimental header to stage these in but this is a bit time sensitive so just backing out for now Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D66332307 fbshipit-source-id: 1d596964e0c893091c541988506e8b80fa6d1957
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Nov 25, 2024
… keywords" Summary: X-link: facebook/react-native#47895 X-link: facebook/yoga#1750 These APIs were only added so that we could do TDD as we work on intrinsic sizing functionality. As of right now they do nothing. We are aiming on publishing a new version of Yoga soon so for the time being we are going to back these out so as not to confuse anyone with this new functionality. Ideally we get to a point where we have some temporary experimental header to stage these in but this is a bit time sensitive so just backing out for now Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D66332307 fbshipit-source-id: 1d596964e0c893091c541988506e8b80fa6d1957
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
These APIs were only added so that we could do TDD as we work on intrinsic sizing functionality. As of right now they do nothing. We are aiming on publishing a new version of Yoga soon so for the time being we are going to back these out so as not to confuse anyone with this new functionality. Ideally we get to a point where we have some temporary experimental header to stage these in but this is a bit time sensitive so just backing out for now
Changelog: [Internal]
Differential Revision: D66332307