Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sunset the value namespace #1720

Closed
wants to merge 3 commits into from
Closed

Sunset the value namespace #1720

wants to merge 3 commits into from

Commits on Oct 9, 2024

  1. Make it so that we can console.log in browser to debug gentest (faceb… 

    …ook#1718)

Summary:

Our gentest works by console.logging the contents of the test it is generating to the browser powered by the driver. The driver then reads the logs and writes it to a file. An unfortunate side effect here is that we cannot console.log to debug how the gentest logic actually works since the driver is expecting formatted code. To get around this I had the driver filter out logs with a certain prefix and add that a helper that logs a message with this prefix to the scripts.

Reviewed By: NickGerleman

Differential Revision: D64011035
    @joevilches @facebook-github-bot
    joevilches authored and facebook-github-bot committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    e03737a View commit details
    Browse the repository at this point in the history

  2. Let gentest properly create *Auto methods for sizes (facebook#1719) 

    Summary:

Right now there is no way to test fixtures with `auto` widths, heights, or flex basis - even though we expose those functions. I updated gentest to generate those functions. Notably, position and margin (the other auto-able props) already account for this.

 I also created `YGAutoTest.html` to test this. Not really testing the capabilities of `auto` here, just if we can create a test about it.

Reviewed By: NickGerleman

Differential Revision: D64125522
    @joevilches @facebook-github-bot
    joevilches authored and facebook-github-bot committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    f6f9d6f View commit details
    Browse the repository at this point in the history

  3. Sunset the value namespace (facebook#1720) 

    Summary:

X-link: facebook/react-native#46930

This is not really needed anymore, we can just use `StyleLength` statics instead

Changelog: [Internal]

Reviewed By: NickGerleman

Differential Revision: D63922280
    @joevilches @facebook-github-bot
    joevilches authored and facebook-github-bot committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    d523c59 View commit details
    Browse the repository at this point in the history