Build with MSVC /W4 #1432
Closed
Build with MSVC /W4 #1432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reference Clang/GCC build has a pretty strict set of warnings enabled. The reference MSVC build has less strict warnings, which can be a problem for MSVC users building at higher warning levels. Let’s see how clean this is, and impact to devx (mismatched from local warnings) for developers mostly using Clang.
|
@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Oct 18, 2023
Summary: The reference Clang/GCC build has a pretty strict set of warnings enabled. The reference MSVC build has less strict warnings, which can be a problem for MSVC users building at higher warning levels (e.g. React Native for Windows in OSS uses `/W4` as its baseline warning level). This bumps up the MSVC warning level to `/W4`, since we are nearly clean already. There are some limitations. E.g. we don't test binary with MSVC (some issues I didn't work out), and only test building statically linked. But but we do have a minimal C benchmark we compile with MSVC. X-link: facebook/yoga#1432 Differential Revision: D50398443 Pulled By: NickGerleman
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Oct 18, 2023
Summary: Pull Request resolved: facebook#41044 The reference Clang/GCC build has a pretty strict set of warnings enabled. The reference MSVC build has less strict warnings, which can be a problem for MSVC users building at higher warning levels (e.g. React Native for Windows in OSS uses `/W4` as its baseline warning level). This bumps up the MSVC warning level to `/W4`, since we are nearly clean already. There are some limitations. E.g. we don't test binary with MSVC (some issues I didn't work out), and only test building statically linked. But but we do have a minimal C benchmark we compile with MSVC. X-link: facebook/yoga#1432 Test Plan: GitHub Actions running benchmark MSVC build. Reviewed By: yungsters Differential Revision: D50398443 Pulled By: NickGerleman fbshipit-source-id: 87a9f521830adea8964aeae2028d05ec50b87d76
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Oct 19, 2023
Summary: X-link: facebook/react-native#41044 The reference Clang/GCC build has a pretty strict set of warnings enabled. The reference MSVC build has less strict warnings, which can be a problem for MSVC users building at higher warning levels (e.g. React Native for Windows in OSS uses `/W4` as its baseline warning level). This bumps up the MSVC warning level to `/W4`, since we are nearly clean already. There are some limitations. E.g. we don't test binary with MSVC (some issues I didn't work out), and only test building statically linked. But but we do have a minimal C benchmark we compile with MSVC. X-link: facebook/yoga#1432 Reviewed By: yungsters Differential Revision: D50398443 Pulled By: NickGerleman fbshipit-source-id: 6616034d79b1a308b32d5d3387bae70f40b7b5ab
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Oct 19, 2023
Summary: Pull Request resolved: #41044 The reference Clang/GCC build has a pretty strict set of warnings enabled. The reference MSVC build has less strict warnings, which can be a problem for MSVC users building at higher warning levels (e.g. React Native for Windows in OSS uses `/W4` as its baseline warning level). This bumps up the MSVC warning level to `/W4`, since we are nearly clean already. There are some limitations. E.g. we don't test binary with MSVC (some issues I didn't work out), and only test building statically linked. But but we do have a minimal C benchmark we compile with MSVC. X-link: facebook/yoga#1432 Test Plan: GitHub Actions running benchmark MSVC build. Reviewed By: yungsters Differential Revision: D50398443 Pulled By: NickGerleman fbshipit-source-id: 6616034d79b1a308b32d5d3387bae70f40b7b5ab
|
@NickGerleman merged this pull request in f1f869b. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Oct 30, 2023
Summary: Pull Request resolved: facebook#41044 The reference Clang/GCC build has a pretty strict set of warnings enabled. The reference MSVC build has less strict warnings, which can be a problem for MSVC users building at higher warning levels (e.g. React Native for Windows in OSS uses `/W4` as its baseline warning level). This bumps up the MSVC warning level to `/W4`, since we are nearly clean already. There are some limitations. E.g. we don't test binary with MSVC (some issues I didn't work out), and only test building statically linked. But but we do have a minimal C benchmark we compile with MSVC. X-link: facebook/yoga#1432 Test Plan: GitHub Actions running benchmark MSVC build. Reviewed By: yungsters Differential Revision: D50398443 Pulled By: NickGerleman fbshipit-source-id: 6616034d79b1a308b32d5d3387bae70f40b7b5ab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reference Clang/GCC build has a pretty strict set of warnings enabled. The reference MSVC build has less strict warnings, which can be a problem for MSVC users building at higher warning levels (e.g. React Native for Windows in OSS uses
/W4as its baseline warning level).This bumps up the MSVC warning level to
/W4, since we are nearly clean already.There are some limitations. E.g. we don't test binary with MSVC (some issues I didn't work out), and only test building statically linked. But but we do have a minimal C benchmark we compile with MSVC.