Remove layoutContext Threading #1376
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D49179244 |
|
This pull request was exported from Phabricator. Differential Revision: D49179244 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 12, 2023
Summary: Pull Request resolved: facebook#1376 kill_with_fire_flamethrower Differential Revision: D49179244 fbshipit-source-id: b0b9d02282e28d649fd22a89d77f91c3045695f1
NickGerleman
force-pushed
the
export-D49179244
branch
from
93a3e52 to
f9d699b
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 12, 2023
Summary: X-link: facebook/yoga#1376 kill_with_fire_flamethrower Differential Revision: D49179244 fbshipit-source-id: 7d23f4abc16ed9ae073686df79aafd80e8442b55
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 12, 2023
Summary: Pull Request resolved: facebook#39401 X-link: facebook/yoga#1376 kill_with_fire_flamethrower Differential Revision: D49179244 fbshipit-source-id: ab8ced071b61425c0a13ef288d0ba560dd5633b1
|
This pull request was exported from Phabricator. Differential Revision: D49179244 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 12, 2023
Summary: X-link: facebook/react-native#39401 Pull Request resolved: facebook#1376 kill_with_fire_flamethrower Differential Revision: D49179244 fbshipit-source-id: 7591bad4ce29955b19dc9d352b20178315d211f8
NickGerleman
force-pushed
the
export-D49179244
branch
from
f9d699b to
c97ea0d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49179244 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 12, 2023
Summary: X-link: facebook/react-native#39401 Pull Request resolved: facebook#1376 kill_with_fire_flamethrower Differential Revision: D49179244 fbshipit-source-id: 0f33b4dcb832fa04dc96603224d25849f5baa79b
NickGerleman
force-pushed
the
export-D49179244
branch
from
c97ea0d to
4566284
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 12, 2023
Summary: Pull Request resolved: facebook#39401 X-link: facebook/yoga#1376 kill_with_fire_flamethrower Differential Revision: D49179244 fbshipit-source-id: 15610d13b4ba119dab99e031d5581d237a30661e
|
This pull request was exported from Phabricator. Differential Revision: D49179244 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 12, 2023
Summary: X-link: facebook/react-native#39401 Pull Request resolved: facebook#1376 kill_with_fire_flamethrower Differential Revision: D49179244 fbshipit-source-id: be3d1fa8c4ff208a3adbe2589f23fafa6b88c74d
NickGerleman
force-pushed
the
export-D49179244
branch
from
4566284 to
13c2339
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 12, 2023
Summary: Pull Request resolved: facebook#39401 X-link: facebook/yoga#1376 kill_with_fire_flamethrower Differential Revision: D49179244 fbshipit-source-id: dbf0f25cc1c8ec59d774d26f41efde12a290938b
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 12, 2023
Summary: X-link: facebook/react-native#39401 Pull Request resolved: facebook#1376 kill_with_fire_flamethrower Differential Revision: D49179244 fbshipit-source-id: 375457b7bbcae78bb03f8e708a72b70e5ecb05f3
NickGerleman
force-pushed
the
export-D49179244
branch
from
13c2339 to
4289200
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49179244 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 12, 2023
Summary: Pull Request resolved: facebook#39401 X-link: facebook/yoga#1376 kill_with_fire_flamethrower Differential Revision: D49179244 fbshipit-source-id: db0a91d63b0a07445f2a6581a004f5f53266358c
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 12, 2023
Summary: Pull Request resolved: facebook#39401 X-link: facebook/yoga#1376 kill_with_fire_flamethrower Reviewed By: rshest Differential Revision: D49179244 fbshipit-source-id: c7a2c14dd3f934ed77d27841902e7565167e322b
|
This pull request was exported from Phabricator. Differential Revision: D49179244 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 12, 2023
Summary: X-link: facebook/react-native#39401 Pull Request resolved: facebook#1376 kill_with_fire_flamethrower Reviewed By: rshest Differential Revision: D49179244 fbshipit-source-id: 76c184c1b72432179d481ef0463b197cdea5b44a
NickGerleman
force-pushed
the
export-D49179244
branch
from
4289200 to
e4166de
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49179244 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 12, 2023
Summary: X-link: facebook/react-native#39401 Pull Request resolved: facebook#1376 kill_with_fire_flamethrower Reviewed By: rshest Differential Revision: D49179244 fbshipit-source-id: 6b5ef24149dc5dfbe5c1dcb27048f4ed640e17b8
NickGerleman
force-pushed
the
export-D49179244
branch
from
e4166de to
170d634
Compare
NickGerleman
force-pushed
the
export-D49179244
branch
from
170d634 to
36c6205
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 12, 2023
Summary: Pull Request resolved: facebook#39401 X-link: facebook/yoga#1376 kill_with_fire_flamethrower Reviewed By: rshest Differential Revision: D49179244 fbshipit-source-id: 5c4ebf9d962e1e57bd7771a305e0cabf9d2e9d00
|
This pull request was exported from Phabricator. Differential Revision: D49179244 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 12, 2023
Summary: X-link: facebook/react-native#39401 Pull Request resolved: facebook#1376 kill_with_fire_flamethrower Reviewed By: rshest Differential Revision: D49179244 fbshipit-source-id: 3094a63a273d7515a169420d3f1ab96fd55766e8
NickGerleman
force-pushed
the
export-D49179244
branch
from
36c6205 to
80b1f35
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 12, 2023
Summary: Pull Request resolved: facebook#39401 X-link: facebook/yoga#1376 kill_with_fire_flamethrower Reviewed By: rshest Differential Revision: D49179244 fbshipit-source-id: 872eb72aca480817c92b69eaa62a249f225762d2
|
This pull request was exported from Phabricator. Differential Revision: D49179244 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 13, 2023
Summary: X-link: facebook/react-native#39401 Pull Request resolved: facebook#1376 kill_with_fire_flamethrower Reviewed By: rshest Differential Revision: D49179244 fbshipit-source-id: 4f0ee3b3245b84d30b3b69f285ba97e1ee800d6b
NickGerleman
force-pushed
the
export-D49179244
branch
from
80b1f35 to
5696c79
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 13, 2023
Summary: Pull Request resolved: facebook#39401 X-link: facebook/yoga#1376 kill_with_fire_flamethrower Reviewed By: rshest Differential Revision: D49179244 fbshipit-source-id: d78310517fbc49adf7b9264b8d9ebed10aac08e1
|
This pull request was exported from Phabricator. Differential Revision: D49179244 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 13, 2023
Summary: X-link: facebook/react-native#39401 Pull Request resolved: facebook#1376 kill_with_fire_flamethrower Reviewed By: rshest Differential Revision: D49179244 fbshipit-source-id: 2d14e44ed0ab19b85b3f3c65b4ff81fba3cc2ab1
NickGerleman
force-pushed
the
export-D49179244
branch
from
5696c79 to
9dd4b53
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 13, 2023
Summary: Pull Request resolved: facebook#39401 X-link: facebook/yoga#1376 kill_with_fire_flamethrower Reviewed By: rshest Differential Revision: D49179244 fbshipit-source-id: 0382def3a307db7187ec25a3c972f76e9a9d1915
|
This pull request was exported from Phabricator. Differential Revision: D49179244 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 13, 2023
Summary: X-link: facebook/react-native#39401 Pull Request resolved: facebook#1376 kill_with_fire_flamethrower Reviewed By: rshest Differential Revision: D49179244 fbshipit-source-id: e3d535f6fde65a956bb67cfbf1eb78d58305e86b
NickGerleman
force-pushed
the
export-D49179244
branch
from
9dd4b53 to
5d04016
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 13, 2023
Summary: Pull Request resolved: facebook#39401 X-link: facebook/yoga#1376 kill_with_fire_flamethrower Reviewed By: rshest Differential Revision: D49179244 fbshipit-source-id: 820bbe5ec0ef795d04ac77bf37659e0150277e19
Summary: Moves `isBaselineLayout` out of `CalculateLayout` into `Baseline.h`. This function is called by flex line justification code, which I have been looking at extracting. Differential Revision: D49177937 fbshipit-source-id: 31b42d1c249d258903b59ff8b88f83fe5151b95f
Summary: To avoid keeping a per-node mapping on native Yoga nodes to Java nodes, a per-layout context was added, to be able to pass information from the start of the layout, to measure functions, log functions, etc. The way this was done was super invasive, and added quite a few private APIs used only by the JNI functions. This change removes the context-using functions from the JNI bindings in favor of it managing its own context. Next diff removes all the cruft. Differential Revision: D49179243 fbshipit-source-id: 9f0277187339cc4d123d339fd7580dcd82bcb8fb
Summary: X-link: facebook/react-native#39401 Pull Request resolved: facebook#1376 kill_with_fire_flamethrower Reviewed By: rshest Differential Revision: D49179244 fbshipit-source-id: 4f680ba32d0afb5b0a46621e39d5ad12e2bbbf04
|
This pull request was exported from Phabricator. Differential Revision: D49179244 |
NickGerleman
force-pushed
the
export-D49179244
branch
from
5d04016 to
0d3268d
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 13, 2023
Summary: Pull Request resolved: facebook#39401 X-link: facebook/yoga#1376 kill_with_fire_flamethrower Reviewed By: rshest Differential Revision: D49179244 fbshipit-source-id: 96054b9b3a826dbea74deff94d37eb1f8e172757
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Sep 13, 2023
Summary: Pull Request resolved: #39401 X-link: facebook/yoga#1376 kill_with_fire_flamethrower Reviewed By: rshest Differential Revision: D49179244 fbshipit-source-id: 9a827e1bd29205254fee5725449191726d6bcf5a
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Sep 13, 2023
Summary: X-link: facebook/react-native#39401 X-link: facebook/yoga#1376 kill_with_fire_flamethrower Reviewed By: rshest Differential Revision: D49179244 fbshipit-source-id: 9a827e1bd29205254fee5725449191726d6bcf5a
|
This pull request has been merged in 0a90b16. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: kill_with_fire_flamethrower
Differential Revision: D49179244