Extract isBaselineLayout() #1375
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D49177937 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 12, 2023
Summary: X-link: facebook/yoga#1375 Moves `isBaselineLayout` out of `CalculateLayout` into `Baseline.h`. This function is called by flex line justification code, which I have been looking at extracting. Differential Revision: D49177937
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 12, 2023
Summary: X-link: facebook/react-native#39400 Moves `isBaselineLayout` out of `CalculateLayout` into `Baseline.h`. This function is called by flex line justification code, which I have been looking at extracting. Differential Revision: D49177937
NickGerleman
force-pushed
the
export-D49177937
branch
from
594dcb3 to
f5ddb75
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49177937 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 12, 2023
Summary: X-link: facebook/yoga#1375 Moves `isBaselineLayout` out of `CalculateLayout` into `Baseline.h`. This function is called by flex line justification code, which I have been looking at extracting. Reviewed By: yungsters Differential Revision: D49177937
NickGerleman
force-pushed
the
export-D49177937
branch
from
f5ddb75 to
dae8271
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 12, 2023
Summary: X-link: facebook/react-native#39400 Moves `isBaselineLayout` out of `CalculateLayout` into `Baseline.h`. This function is called by flex line justification code, which I have been looking at extracting. Reviewed By: yungsters Differential Revision: D49177937
|
This pull request was exported from Phabricator. Differential Revision: D49177937 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 12, 2023
Summary: X-link: facebook/yoga#1375 Moves `isBaselineLayout` out of `CalculateLayout` into `Baseline.h`. This function is called by flex line justification code, which I have been looking at extracting. Reviewed By: yungsters Differential Revision: D49177937
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 12, 2023
Summary: X-link: facebook/react-native#39400 Moves `isBaselineLayout` out of `CalculateLayout` into `Baseline.h`. This function is called by flex line justification code, which I have been looking at extracting. Reviewed By: yungsters Differential Revision: D49177937
NickGerleman
force-pushed
the
export-D49177937
branch
from
dae8271 to
328cc48
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49177937 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 12, 2023
Summary: X-link: facebook/react-native#39400 Moves `isBaselineLayout` out of `CalculateLayout` into `Baseline.h`. This function is called by flex line justification code, which I have been looking at extracting. Reviewed By: yungsters Differential Revision: D49177937
NickGerleman
force-pushed
the
export-D49177937
branch
from
328cc48 to
743243e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49177937 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 12, 2023
Summary: X-link: facebook/yoga#1375 Moves `isBaselineLayout` out of `CalculateLayout` into `Baseline.h`. This function is called by flex line justification code, which I have been looking at extracting. Reviewed By: yungsters Differential Revision: D49177937
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 12, 2023
Summary: X-link: facebook/react-native#39400 Moves `isBaselineLayout` out of `CalculateLayout` into `Baseline.h`. This function is called by flex line justification code, which I have been looking at extracting. Reviewed By: yungsters Differential Revision: D49177937
NickGerleman
force-pushed
the
export-D49177937
branch
from
743243e to
ce99700
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 12, 2023
Summary: X-link: facebook/yoga#1375 Moves `isBaselineLayout` out of `CalculateLayout` into `Baseline.h`. This function is called by flex line justification code, which I have been looking at extracting. Reviewed By: yungsters Differential Revision: D49177937
|
This pull request was exported from Phabricator. Differential Revision: D49177937 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 12, 2023
Summary: X-link: facebook/react-native#39400 Moves `isBaselineLayout` out of `CalculateLayout` into `Baseline.h`. This function is called by flex line justification code, which I have been looking at extracting. Reviewed By: yungsters Differential Revision: D49177937
NickGerleman
force-pushed
the
export-D49177937
branch
from
ce99700 to
90baf57
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 12, 2023
Summary: X-link: facebook/yoga#1375 Moves `isBaselineLayout` out of `CalculateLayout` into `Baseline.h`. This function is called by flex line justification code, which I have been looking at extracting. Reviewed By: yungsters Differential Revision: D49177937
|
This pull request was exported from Phabricator. Differential Revision: D49177937 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 13, 2023
Summary: X-link: facebook/react-native#39400 Moves `isBaselineLayout` out of `CalculateLayout` into `Baseline.h`. This function is called by flex line justification code, which I have been looking at extracting. Reviewed By: yungsters Differential Revision: D49177937
NickGerleman
force-pushed
the
export-D49177937
branch
from
90baf57 to
226375d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49177937 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 13, 2023
Summary: X-link: facebook/yoga#1375 Moves `isBaselineLayout` out of `CalculateLayout` into `Baseline.h`. This function is called by flex line justification code, which I have been looking at extracting. Reviewed By: yungsters Differential Revision: D49177937
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 13, 2023
Summary: X-link: facebook/react-native#39400 Moves `isBaselineLayout` out of `CalculateLayout` into `Baseline.h`. This function is called by flex line justification code, which I have been looking at extracting. Reviewed By: yungsters Differential Revision: D49177937
NickGerleman
force-pushed
the
export-D49177937
branch
from
226375d to
141760b
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 13, 2023
Summary: X-link: facebook/yoga#1375 Moves `isBaselineLayout` out of `CalculateLayout` into `Baseline.h`. This function is called by flex line justification code, which I have been looking at extracting. Reviewed By: yungsters Differential Revision: D49177937
|
This pull request was exported from Phabricator. Differential Revision: D49177937 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 13, 2023
Summary: X-link: facebook/react-native#39400 Moves `isBaselineLayout` out of `CalculateLayout` into `Baseline.h`. This function is called by flex line justification code, which I have been looking at extracting. Reviewed By: yungsters Differential Revision: D49177937
NickGerleman
force-pushed
the
export-D49177937
branch
from
141760b to
9c64041
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49177937 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 13, 2023
Summary: X-link: facebook/yoga#1375 Moves `isBaselineLayout` out of `CalculateLayout` into `Baseline.h`. This function is called by flex line justification code, which I have been looking at extracting. Reviewed By: yungsters Differential Revision: D49177937
Summary: X-link: facebook/react-native#39400 Moves `isBaselineLayout` out of `CalculateLayout` into `Baseline.h`. This function is called by flex line justification code, which I have been looking at extracting. Reviewed By: yungsters Differential Revision: D49177937
NickGerleman
force-pushed
the
export-D49177937
branch
from
9c64041 to
f7c4f46
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 13, 2023
Summary: X-link: facebook/yoga#1375 Moves `isBaselineLayout` out of `CalculateLayout` into `Baseline.h`. This function is called by flex line justification code, which I have been looking at extracting. Reviewed By: yungsters Differential Revision: D49177937
|
This pull request was exported from Phabricator. Differential Revision: D49177937 |
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Sep 13, 2023
Summary: X-link: facebook/yoga#1375 Pull Request resolved: #39400 Moves `isBaselineLayout` out of `CalculateLayout` into `Baseline.h`. This function is called by flex line justification code, which I have been looking at extracting. Reviewed By: yungsters Differential Revision: D49177937 fbshipit-source-id: 02c13aa0b02b26cb60ef197473b90e06d53d5f8d
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Sep 13, 2023
Summary: X-link: facebook/yoga#1375 X-link: facebook/react-native#39400 Moves `isBaselineLayout` out of `CalculateLayout` into `Baseline.h`. This function is called by flex line justification code, which I have been looking at extracting. Reviewed By: yungsters Differential Revision: D49177937 fbshipit-source-id: 02c13aa0b02b26cb60ef197473b90e06d53d5f8d
|
This pull request has been merged in 700be8c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebook/react-native#39400
Moves
isBaselineLayoutout ofCalculateLayoutintoBaseline.h. This function is called by flex line justification code, which I have been looking at extracting.Differential Revision: D49177937