Breaking: Remove "UseLegacyStretchBehaviour" functions #1368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D49131250 |
|
This pull request was exported from Phabricator. Differential Revision: D49131250 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 10, 2023
Summary: Pull Request resolved: facebook#1368 X-link: facebook/react-native#39372 These were marked as deprecated as part of the public Yoga 2.0 release, and were alredy emitting deprecation warnings. Remove them. Differential Revision: D49131250 fbshipit-source-id: f3addeaa4984914993ba57633c85b7aad7cecac7
NickGerleman
force-pushed
the
export-D49131250
branch
from
d20c512 to
dbc34be
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 10, 2023
Summary: X-link: facebook/yoga#1368 Pull Request resolved: facebook#39372 These were marked as deprecated as part of the public Yoga 2.0 release, and were alredy emitting deprecation warnings. Remove them. Differential Revision: D49131250 fbshipit-source-id: b7261d567f74be946da8138c82a28e45eacaf121
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 10, 2023
Summary: X-link: facebook/yoga#1368 Pull Request resolved: facebook#39372 These were marked as deprecated as part of the public Yoga 2.0 release, and were alredy emitting deprecation warnings. Remove them. Differential Revision: D49131250 fbshipit-source-id: cf08e4d2412fbff08fa88d882f584d275b856d6d
|
This pull request was exported from Phabricator. Differential Revision: D49131250 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 10, 2023
Summary: Pull Request resolved: facebook#1368 X-link: facebook/react-native#39372 These were marked as deprecated as part of the public Yoga 2.0 release, and were alredy emitting deprecation warnings. Remove them. Differential Revision: D49131250 fbshipit-source-id: 97e94d374a5f5e1a8654d8a519aab1eed4bebf8a
NickGerleman
force-pushed
the
export-D49131250
branch
from
dbc34be to
78fdab1
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 10, 2023
Summary: X-link: facebook/yoga#1368 Pull Request resolved: facebook#39372 These were marked as deprecated as part of the public Yoga 2.0 release, and were alredy emitting deprecation warnings. Remove them. Differential Revision: D49131250 fbshipit-source-id: 441a42564d00c96db0bad517b4af8ae02a858717
|
This pull request was exported from Phabricator. Differential Revision: D49131250 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 10, 2023
Summary: Pull Request resolved: facebook#1368 X-link: facebook/react-native#39372 These were marked as deprecated as part of the public Yoga 2.0 release, and were alredy emitting deprecation warnings. Remove them. Differential Revision: D49131250 fbshipit-source-id: cf6101bd801d72ab7e6a67e65590e03f25a80fa8
NickGerleman
force-pushed
the
export-D49131250
branch
from
78fdab1 to
c90a16b
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 10, 2023
Summary: X-link: facebook/yoga#1368 Pull Request resolved: facebook#39372 These were marked as deprecated as part of the public Yoga 2.0 release, and were alredy emitting deprecation warnings. Remove them. Differential Revision: D49131250 fbshipit-source-id: 39dbeb7c21e37333872f77fcfc5c75f458991c67
|
This pull request was exported from Phabricator. Differential Revision: D49131250 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 10, 2023
Summary: Pull Request resolved: facebook#1368 X-link: facebook/react-native#39372 These were marked as deprecated as part of the public Yoga 2.0 release, and were alredy emitting deprecation warnings. Remove them. Differential Revision: D49131250 fbshipit-source-id: 4e6acfbaa1cd26c03bb7db90ba26529fe7c3f48b
NickGerleman
force-pushed
the
export-D49131250
branch
from
c90a16b to
4373dc0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49131250 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 11, 2023
Summary: Pull Request resolved: facebook#1368 X-link: facebook/react-native#39372 These were marked as deprecated as part of the public Yoga 2.0 release, and were alredy emitting deprecation warnings. Remove them. Reviewed By: javache Differential Revision: D49131250 fbshipit-source-id: cdbb51e026df1fee51ee76bdb7b2724a425a51dd
NickGerleman
force-pushed
the
export-D49131250
branch
from
4373dc0 to
f9ec07f
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 11, 2023
Summary: X-link: facebook/yoga#1368 Pull Request resolved: facebook#39372 These were marked as deprecated as part of the public Yoga 2.0 release, and were alredy emitting deprecation warnings. Remove them. Reviewed By: javache Differential Revision: D49131250 fbshipit-source-id: eb6e0b254b1c40151e4dde38ce375a563e33ee6f
|
This pull request was exported from Phabricator. Differential Revision: D49131250 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 12, 2023
Summary: Pull Request resolved: facebook#1368 X-link: facebook/react-native#39372 These were marked as deprecated as part of the public Yoga 2.0 release, and were alredy emitting deprecation warnings. Remove them. Reviewed By: javache Differential Revision: D49131250 fbshipit-source-id: b6d5e3a7109e7ecd4163a7986cb522e14ab6c1d7
NickGerleman
force-pushed
the
export-D49131250
branch
from
f9ec07f to
d246b7d
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 12, 2023
Summary: X-link: facebook/yoga#1368 Pull Request resolved: facebook#39372 These were marked as deprecated as part of the public Yoga 2.0 release, and were alredy emitting deprecation warnings. Remove them. Reviewed By: javache Differential Revision: D49131250 fbshipit-source-id: 9f4fcd3dcea2757130a048197643db78d6ac9761
|
This pull request was exported from Phabricator. Differential Revision: D49131250 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 12, 2023
Summary: Pull Request resolved: facebook#1368 X-link: facebook/react-native#39372 These were marked as deprecated as part of the public Yoga 2.0 release, and were alredy emitting deprecation warnings. Remove them. Reviewed By: javache Differential Revision: D49131250 fbshipit-source-id: 89d91e672f3f92c1660aaaee2186c6b384eaddaa
NickGerleman
force-pushed
the
export-D49131250
branch
from
d246b7d to
7e88885
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 12, 2023
Summary: X-link: facebook/yoga#1368 Pull Request resolved: facebook#39372 These were marked as deprecated as part of the public Yoga 2.0 release, and were alredy emitting deprecation warnings. Remove them. Reviewed By: javache Differential Revision: D49131250 fbshipit-source-id: 4a8e339abe8cc6329546f832d972a40d077de0ab
|
This pull request was exported from Phabricator. Differential Revision: D49131250 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 12, 2023
Summary: Pull Request resolved: facebook#1368 X-link: facebook/react-native#39372 These were marked as deprecated as part of the public Yoga 2.0 release, and were alredy emitting deprecation warnings. Remove them. Reviewed By: javache Differential Revision: D49131250 fbshipit-source-id: 178828b49f1e4a6dc0620669b7cb3bbc522b9444
NickGerleman
force-pushed
the
export-D49131250
branch
from
7e88885 to
e8ea313
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 12, 2023
Summary: X-link: facebook/yoga#1368 Pull Request resolved: facebook#39372 These were marked as deprecated as part of the public Yoga 2.0 release, and were alredy emitting deprecation warnings. Remove them. Reviewed By: javache Differential Revision: D49131250 fbshipit-source-id: abd366ecb8d9fab7a49921a7fe44dc25cb9430b2
Summary: This changes public Yoga API to in more places accept const structures where before they required mutable ones. This tries to avoid more breaking changes yet, e.g. changing callbacks to require clients do not modify nodes when they are passed for logging. We also don't have const variants for returning child structures which would allow mutation of dependencies of the const object. These would need new names under the public API, since we do not have operator overloading in C. Differential Revision: D49130412 fbshipit-source-id: f684c47671f6c45f1a859462e2513d998471e48b
Summary: Pull Request resolved: facebook#1369 X-link: facebook/react-native#39370 This fixes const-correctness of callbacks (e.g. not letting a logger function modify nodes during layout). This helps us to continue to fix const-correctness issues inside of Yoga. This change is breaking to the public API, since it requires a change in signature passed to Yoga. Changelog: [Internal] Differential Revision: https://internalfb.com/D49130714 fbshipit-source-id: 855a4fdb9dbeef284bd0f00cfa3af03d9d6fc328
Summary: Yoga's public API exposes indices most often as `uint32_t`, with exception of clone callbacks which are `int32_t`. Yoga internally represents these indices as `size_t` when dealing with the child vector, and this is the true index. This changes the API to consistently be `size_t`. This should not be breaking for most users, but will cause breaks where: 1. Users set a clone node callback (I think this should be rare. RN uses it, but only because it relies on a separate private API). 2. Callers of `YGNodeGetChildCount()` are assigning to an int with less width than `size_t` and have strong warnings enabled. 3. Using a newer Yoga binary with older source, since we are not preserving ABI compatibility (Yoga in general does not aim to be ABI stable between major versions, only ABI safe for a given set of sources). Differential Revision: D49130914 fbshipit-source-id: 31ad14864f94952d36e36e5b99df6d82caf5ea16
Summary: This was added in facebook#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it. Differential Revision: D49131207 fbshipit-source-id: 72423f737c3cabf5c44a7b9793c47450da58fb44
Summary: Pull Request resolved: facebook#1368 X-link: facebook/react-native#39372 These were marked as deprecated as part of the public Yoga 2.0 release, and were alredy emitting deprecation warnings. Remove them. Reviewed By: javache Differential Revision: D49131250 fbshipit-source-id: 1959e0a330f49ec4ce99303b66354aafb20aa26b
|
This pull request was exported from Phabricator. Differential Revision: D49131250 |
NickGerleman
force-pushed
the
export-D49131250
branch
from
e8ea313 to
66ac052
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 12, 2023
Summary: X-link: facebook/yoga#1368 Pull Request resolved: facebook#39372 These were marked as deprecated as part of the public Yoga 2.0 release, and were alredy emitting deprecation warnings. Remove them. Reviewed By: javache Differential Revision: D49131250 fbshipit-source-id: a85f4355acf708e4e68a9bed69550aed0dc934cc
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Sep 12, 2023
Summary: X-link: facebook/yoga#1368 X-link: facebook/react-native#39372 These were marked as deprecated as part of the public Yoga 2.0 release, and were alredy emitting deprecation warnings. Remove them. Reviewed By: javache Differential Revision: D49131250 fbshipit-source-id: cc1d4e8b179697b9a11a685f4fc4e9d36e1a26a0
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Sep 12, 2023
Summary: X-link: facebook/yoga#1368 Pull Request resolved: #39372 These were marked as deprecated as part of the public Yoga 2.0 release, and were alredy emitting deprecation warnings. Remove them. Reviewed By: javache Differential Revision: D49131250 fbshipit-source-id: cc1d4e8b179697b9a11a685f4fc4e9d36e1a26a0
|
This pull request has been merged in c35f881. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: These were marked as deprecated as part of the public Yoga 2.0 release, and were alredy emitting deprecation warnings. Remove them.
Differential Revision: D49131250