Enable -Wconversion
#1359
Closed
Enable -Wconversion
#1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D48954777 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 5, 2023
Summary: X-link: facebook/yoga#1359 This enables clang warnings around potentially unsafe conversions, such as those with mismatched signedness, or ones which may lead to truncation. This should catch issues in local development which create errors for MSVC (e.g. Dash), who's default `/W3` includes warnings akin to `-Wshorten-64-to-32`. This full set of warnings here is a tad spammy, but probably more useful than not. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D48954777 fbshipit-source-id: 551aed88bfcd31a9857d5c3302d9cf93955803ad
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 5, 2023
Summary: X-link: facebook/react-native#39291 This enables clang warnings around potentially unsafe conversions, such as those with mismatched signedness, or ones which may lead to truncation. This should catch issues in local development which create errors for MSVC (e.g. Dash), who's default `/W3` includes warnings akin to `-Wshorten-64-to-32`. This full set of warnings here is a tad spammy, but probably more useful than not. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D48954777
NickGerleman
force-pushed
the
export-D48954777
branch
from
0b3f36d
to
1f8b398
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 5, 2023
Summary: X-link: facebook/yoga#1359 This enables clang warnings around potentially unsafe conversions, such as those with mismatched signedness, or ones which may lead to truncation. This should catch issues in local development which create errors for MSVC (e.g. Dash), who's default `/W3` includes warnings akin to `-Wshorten-64-to-32`. This full set of warnings here is a tad spammy, but probably more useful than not. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D48954777
|
This pull request was exported from Phabricator. Differential Revision: D48954777 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 5, 2023
Summary: X-link: facebook/react-native#39291 This enables clang warnings around potentially unsafe conversions, such as those with mismatched signedness, or ones which may lead to truncation. This should catch issues in local development which create errors for MSVC (e.g. Dash), who's default `/W3` includes warnings akin to `-Wshorten-64-to-32`. This full set of warnings here is a tad spammy, but probably more useful than not. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D48954777
NickGerleman
force-pushed
the
export-D48954777
branch
from
1f8b398
to
191816a
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 5, 2023
Summary: X-link: facebook/yoga#1359 This enables clang warnings around potentially unsafe conversions, such as those with mismatched signedness, or ones which may lead to truncation. This should catch issues in local development which create errors for MSVC (e.g. Dash), who's default `/W3` includes warnings akin to `-Wshorten-64-to-32`. This full set of warnings here is a tad spammy, but probably more useful than not. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D48954777
|
This pull request was exported from Phabricator. Differential Revision: D48954777 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 5, 2023
Summary: X-link: facebook/react-native#39291 This enables clang warnings around potentially unsafe conversions, such as those with mismatched signedness, or ones which may lead to truncation. This should catch issues in local development which create errors for MSVC (e.g. Dash), who's default `/W3` includes warnings akin to `-Wshorten-64-to-32`. This full set of warnings here is a tad spammy, but probably more useful than not. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D48954777
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 5, 2023
Summary: X-link: facebook/yoga#1359 This enables clang warnings around potentially unsafe conversions, such as those with mismatched signedness, or ones which may lead to truncation. This should catch issues in local development which create errors for MSVC (e.g. Dash), who's default `/W3` includes warnings akin to `-Wshorten-64-to-32`. This full set of warnings here is a tad spammy, but probably more useful than not. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D48954777
NickGerleman
force-pushed
the
export-D48954777
branch
from
191816a
to
dbdb0e7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48954777 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 5, 2023
Summary: X-link: facebook/yoga#1359 This enables clang warnings around potentially unsafe conversions, such as those with mismatched signedness, or ones which may lead to truncation. This should catch issues in local development which create errors for MSVC (e.g. Dash), who's default `/W3` includes warnings akin to `-Wshorten-64-to-32`. This full set of warnings here is a tad spammy, but probably more useful than not. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D48954777
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 5, 2023
Summary: X-link: facebook/react-native#39291 This enables clang warnings around potentially unsafe conversions, such as those with mismatched signedness, or ones which may lead to truncation. This should catch issues in local development which create errors for MSVC (e.g. Dash), who's default `/W3` includes warnings akin to `-Wshorten-64-to-32`. This full set of warnings here is a tad spammy, but probably more useful than not. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D48954777
NickGerleman
force-pushed
the
export-D48954777
branch
from
dbdb0e7
to
ebf76b5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48954777 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 5, 2023
Summary: X-link: facebook/yoga#1359 This enables clang warnings around potentially unsafe conversions, such as those with mismatched signedness, or ones which may lead to truncation. This should catch issues in local development which create errors for MSVC (e.g. Dash), who's default `/W3` includes warnings akin to `-Wshorten-64-to-32`. This full set of warnings here is a tad spammy, but probably more useful than not. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D48954777
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 5, 2023
Summary: X-link: facebook/react-native#39291 This enables clang warnings around potentially unsafe conversions, such as those with mismatched signedness, or ones which may lead to truncation. This should catch issues in local development which create errors for MSVC (e.g. Dash), who's default `/W3` includes warnings akin to `-Wshorten-64-to-32`. This full set of warnings here is a tad spammy, but probably more useful than not. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D48954777
NickGerleman
force-pushed
the
export-D48954777
branch
from
ebf76b5
to
a3511a3
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 5, 2023
Summary: X-link: facebook/yoga#1359 This enables clang warnings around potentially unsafe conversions, such as those with mismatched signedness, or ones which may lead to truncation. This should catch issues in local development which create errors for MSVC (e.g. Dash), who's default `/W3` includes warnings akin to `-Wshorten-64-to-32`. This full set of warnings here is a tad spammy, but probably more useful than not. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D48954777
|
This pull request was exported from Phabricator. Differential Revision: D48954777 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 5, 2023
Summary: X-link: facebook/react-native#39291 This enables clang warnings around potentially unsafe conversions, such as those with mismatched signedness, or ones which may lead to truncation. This should catch issues in local development which create errors for MSVC (e.g. Dash), who's default `/W3` includes warnings akin to `-Wshorten-64-to-32`. This full set of warnings here is a tad spammy, but probably more useful than not. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D48954777
NickGerleman
force-pushed
the
export-D48954777
branch
from
a3511a3
to
1f709d6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48954777 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 5, 2023
Summary: X-link: facebook/react-native#39291 This enables clang warnings around potentially unsafe conversions, such as those with mismatched signedness, or ones which may lead to truncation. This should catch issues in local development which create errors for MSVC (e.g. Dash), who's default `/W3` includes warnings akin to `-Wshorten-64-to-32`. This full set of warnings here is a tad spammy, but probably more useful than not. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D48954777
NickGerleman
force-pushed
the
export-D48954777
branch
from
09b4ff3
to
b67c987
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 5, 2023
Summary: X-link: facebook/yoga#1359 This enables clang warnings around potentially unsafe conversions, such as those with mismatched signedness, or ones which may lead to truncation. This should catch issues in local development which create errors for MSVC (e.g. Dash), who's default `/W3` includes warnings akin to `-Wshorten-64-to-32`. This full set of warnings here is a tad spammy, but probably more useful than not. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D48954777
|
This pull request was exported from Phabricator. Differential Revision: D48954777 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 5, 2023
Summary: X-link: facebook/react-native#39291 This enables clang warnings around potentially unsafe conversions, such as those with mismatched signedness, or ones which may lead to truncation. This should catch issues in local development which create errors for MSVC (e.g. Dash), who's default `/W3` includes warnings akin to `-Wshorten-64-to-32`. This full set of warnings here is a tad spammy, but probably more useful than not. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D48954777
NickGerleman
force-pushed
the
export-D48954777
branch
from
b67c987
to
0f8d025
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48954777 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 5, 2023
Summary: X-link: facebook/react-native#39291 This enables clang warnings around potentially unsafe conversions, such as those with mismatched signedness, or ones which may lead to truncation. This should catch issues in local development which create errors for MSVC (e.g. Dash), who's default `/W3` includes warnings akin to `-Wshorten-64-to-32`. This full set of warnings here is a tad spammy, but probably more useful than not. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D48954777
NickGerleman
force-pushed
the
export-D48954777
branch
from
0f8d025
to
6f47973
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48954777 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 5, 2023
Summary: X-link: facebook/react-native#39291 This enables clang warnings around potentially unsafe conversions, such as those with mismatched signedness, or ones which may lead to truncation. This should catch issues in local development which create errors for MSVC (e.g. Dash), who's default `/W3` includes warnings akin to `-Wshorten-64-to-32`. This full set of warnings here is a tad spammy, but probably more useful than not. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D48954777
NickGerleman
force-pushed
the
export-D48954777
branch
from
6f47973
to
52838c8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48954777 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 5, 2023
Summary: X-link: facebook/react-native#39291 This enables clang warnings around potentially unsafe conversions, such as those with mismatched signedness, or ones which may lead to truncation. This should catch issues in local development which create errors for MSVC (e.g. Dash), who's default `/W3` includes warnings akin to `-Wshorten-64-to-32`. This full set of warnings here is a tad spammy, but probably more useful than not. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D48954777
NickGerleman
force-pushed
the
export-D48954777
branch
from
52838c8
to
b3134b5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48954777 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 5, 2023
Summary: X-link: facebook/yoga#1359 This enables clang warnings around potentially unsafe conversions, such as those with mismatched signedness, or ones which may lead to truncation. This should catch issues in local development which create errors for MSVC (e.g. Dash), who's default `/W3` includes warnings akin to `-Wshorten-64-to-32`. This full set of warnings here is a tad spammy, but probably more useful than not. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D48954777
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 5, 2023
Summary: X-link: facebook/react-native#39291 This enables clang warnings around potentially unsafe conversions, such as those with mismatched signedness, or ones which may lead to truncation. This should catch issues in local development which create errors for MSVC (e.g. Dash), who's default `/W3` includes warnings akin to `-Wshorten-64-to-32`. This full set of warnings here is a tad spammy, but probably more useful than not. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D48954777
NickGerleman
force-pushed
the
export-D48954777
branch
from
b3134b5
to
eb305e5
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 5, 2023
Summary: X-link: facebook/yoga#1359 This enables clang warnings around potentially unsafe conversions, such as those with mismatched signedness, or ones which may lead to truncation. This should catch issues in local development which create errors for MSVC (e.g. Dash), who's default `/W3` includes warnings akin to `-Wshorten-64-to-32`. This full set of warnings here is a tad spammy, but probably more useful than not. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D48954777
|
This pull request was exported from Phabricator. Differential Revision: D48954777 |
Summary: X-link: facebook/react-native#39291 This enables clang warnings around potentially unsafe conversions, such as those with mismatched signedness, or ones which may lead to truncation. This should catch issues in local development which create errors for MSVC (e.g. Dash), who's default `/W3` includes warnings akin to `-Wshorten-64-to-32`. This full set of warnings here is a tad spammy, but probably more useful than not. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D48954777
NickGerleman
force-pushed
the
export-D48954777
branch
from
eb305e5
to
72e8bda
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 6, 2023
Summary: X-link: facebook/yoga#1359 This enables clang warnings around potentially unsafe conversions, such as those with mismatched signedness, or ones which may lead to truncation. This should catch issues in local development which create errors for MSVC (e.g. Dash), who's default `/W3` includes warnings akin to `-Wshorten-64-to-32`. This full set of warnings here is a tad spammy, but probably more useful than not. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D48954777
|
This pull request was exported from Phabricator. Differential Revision: D48954777 |
|
This pull request has been merged in aee43a5. |
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Sep 6, 2023
Summary: Pull Request resolved: #39291 X-link: facebook/yoga#1359 This enables clang warnings around potentially unsafe conversions, such as those with mismatched signedness, or ones which may lead to truncation. This should catch issues in local development which create errors for MSVC (e.g. Dash), who's default `/W3` includes warnings akin to `-Wshorten-64-to-32`. This full set of warnings here is a tad spammy, but probably more useful than not. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D48954777 fbshipit-source-id: 1ccc07b99d09d1c2d428158149698ffd04025605
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Sep 6, 2023
Summary: X-link: facebook/react-native#39291 X-link: facebook/yoga#1359 This enables clang warnings around potentially unsafe conversions, such as those with mismatched signedness, or ones which may lead to truncation. This should catch issues in local development which create errors for MSVC (e.g. Dash), who's default `/W3` includes warnings akin to `-Wshorten-64-to-32`. This full set of warnings here is a tad spammy, but probably more useful than not. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D48954777 fbshipit-source-id: 1ccc07b99d09d1c2d428158149698ffd04025605
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This enables clang warnings around potentially unsafe conversions, such as those with mismatched signedness, or ones which may lead to truncation.
This should catch issues in local development which create errors for MSVC (e.g. Dash), who's default
/W3includes warnings akin to-Wshorten-64-to-32.This full set of warnings here is a tad spammy, but probably more useful than not.
Changelog: [Internal]
Reviewed By: yungsters
Differential Revision: D48954777