Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stale flex basis value used with cached values #1161

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Stale flex basis value used with cached values #1161

wants to merge 4 commits into from

Commits on Sep 29, 2022

  1. Stale flex basis value used with cached values 

    Summary:
We're occasionally seeing text truncation occur on Windows. It appears to occur when a cached main axis value is supplied to the flex basis computation for children, resulting in a stale flex basis value getting used.

This diff just contributes a unit test that reliably reproduces this case.

Differential Revision: D39929963

fbshipit-source-id: 5bae1de3f1498dbc45e42a76184d4269e01a12da
    @rozele @facebook-github-bot
    rozele authored and facebook-github-bot committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    0a323a8 View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2022

  1. Merge branch 'main' into export-D39929963

    @NickGerleman
    NickGerleman authored Dec 29, 2022
    Configuration menu
    Copy the full SHA
    8a33dd5 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2023

  1. Merge branch 'main' into export-D39929963

    @NickGerleman
    NickGerleman authored Jan 16, 2023
    Configuration menu
    Copy the full SHA
    5df8055 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into export-D39929963

    @NickGerleman
    NickGerleman authored Jan 16, 2023
    Configuration menu
    Copy the full SHA
    876425a View commit details
    Browse the repository at this point in the history