Skip to content

Commit

Permalink
Try building with /W4
Browse files Browse the repository at this point in the history
The reference Clang/GCC build has a pretty strict set of warnings enabled. The reference MSVC build has less strict warnings, which can be a problem for MSVC users building at higher warning levels.

Let’s see how clean this is, and impact to devx (mismatched from local warnings) for developers mostly using Clang.
  • Loading branch information
NickGerleman authored Oct 18, 2023
1 parent b40e44c commit 97742e9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cmake/project-defaults.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ add_compile_options(
# "Standard C++ exception handling" (C++ stack unwinding including extern c)
/EHsc
# Enable warnings and warnings as errors
/W3
/W4
/WX
# Disable RTTI
$<$<COMPILE_LANGUAGE:CXX>:/GR->
Expand Down

0 comments on commit 97742e9

Please sign in to comment.