No longer skip margin_start and margin_end row reverse tests

Summary: These are fixed now! Reviewed By: NickGerleman Differential Revision: D50200030 fbshipit-source-id: ac3e80e33d8c35440e342a10cfd3246161ee9018
facebook · Oct 12, 2023 · 3fbd92b · 3fbd92b
1 parent f4337fb
commit 3fbd92b
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 12 deletions.
diff --git a/gentest/fixtures/YGFlexDirectionTest.html b/gentest/fixtures/YGFlexDirectionTest.html
@@ -41,8 +41,7 @@
 </div>
 
 <!-- gentest.rb will swap margin-start to margin-left. This is needed to use YGEdgeStart instead of YGEdgeLeft in the generated tests -->
-<!-- TODO: Yoga flips marginStart and marginEnd with rowReverse direction -->
-<div id="flex_direction_row_reverse_margin_start" data-disabled="true" style="height: 100px; width: 100px; flex-direction: row-reverse; margin-start: 100px;">
+<div id="flex_direction_row_reverse_margin_start" style="height: 100px; width: 100px; flex-direction: row-reverse; margin-start: 100px;">
   <div style="width: 10px;"></div>
   <div style="width: 10px;"></div>
   <div style="width: 10px;"></div>
@@ -54,8 +53,7 @@
   <div style="width: 10px;"></div>
 </div>
 
-<!-- TODO: Yoga flips marginStart and marginEnd with rowReverse direction -->
-<div id="flex_direction_row_reverse_margin_end" data-disabled="true" style="height: 100px; width: 100px; flex-direction: row-reverse; margin-end: 100px;">
+<div id="flex_direction_row_reverse_margin_end" style="height: 100px; width: 100px; flex-direction: row-reverse; margin-end: 100px;">
   <div style="width: 10px;"></div>
   <div style="width: 10px;"></div>
   <div style="width: 10px;"></div>

diff --git a/java/tests/com/facebook/yoga/YGFlexDirectionTest.java b/java/tests/com/facebook/yoga/YGFlexDirectionTest.java
@@ -499,7 +499,6 @@ public void test_flex_direction_row_reverse_margin_left() {
   }
 
   @Test
-  @Ignore
   public void test_flex_direction_row_reverse_margin_start() {
     YogaConfig config = YogaConfigFactory.create();
     config.setExperimentalFeatureEnabled(YogaExperimentalFeature.ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true);
@@ -638,7 +637,6 @@ public void test_flex_direction_row_reverse_margin_right() {
   }
 
   @Test
-  @Ignore
   public void test_flex_direction_row_reverse_margin_end() {
     YogaConfig config = YogaConfigFactory.create();
     config.setExperimentalFeatureEnabled(YogaExperimentalFeature.ABSOLUTE_PERCENTAGE_AGAINST_PADDING_EDGE, true);

diff --git a/javascript/tests/generated/YGFlexDirectionTest.test.ts b/javascript/tests/generated/YGFlexDirectionTest.test.ts
@@ -540,7 +540,7 @@ test('flex_direction_row_reverse_margin_left', () => {
     config.free();
   }
 });
-test.skip('flex_direction_row_reverse_margin_start', () => {
+test('flex_direction_row_reverse_margin_start', () => {
   const config = Yoga.Config.create();
   let root;
 
@@ -690,7 +690,7 @@ test('flex_direction_row_reverse_margin_right', () => {
     config.free();
   }
 });
-test.skip('flex_direction_row_reverse_margin_end', () => {
+test('flex_direction_row_reverse_margin_end', () => {
   const config = Yoga.Config.create();
   let root;
 

diff --git a/tests/generated/YGFlexDirectionTest.cpp b/tests/generated/YGFlexDirectionTest.cpp
@@ -492,8 +492,6 @@ TEST(YogaTest, flex_direction_row_reverse_margin_left) {
 }
 
 TEST(YogaTest, flex_direction_row_reverse_margin_start) {
-  GTEST_SKIP();
-
   const YGConfigRef config = YGConfigNew();
   YGConfigSetExperimentalFeatureEnabled(config, YGExperimentalFeatureAbsolutePercentageAgainstPaddingEdge, true);
 
@@ -634,8 +632,6 @@ TEST(YogaTest, flex_direction_row_reverse_margin_right) {
 }
 
 TEST(YogaTest, flex_direction_row_reverse_margin_end) {
-  GTEST_SKIP();
-
   const YGConfigRef config = YGConfigNew();
   YGConfigSetExperimentalFeatureEnabled(config, YGExperimentalFeatureAbsolutePercentageAgainstPaddingEdge, true);