feat(@stylexjs/eslint-plugin): Accept { from: string, as: string } syntax in validImports option for RSD #569
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed / motivation ?
React Strict DOM recently removed their eslint plugin and I'm considering migrating to
@stylexjs/eslint-plugin
.However, react-strict-dom exports
stylex
undercss
object, and it is it incompatible with currentvalidImports
option in the eslint plugin.e.g. This doesn't work:
I have added
{ from: string, as: string }
syntax similar toimportSources
option in the babel plugin for compatibility with RSD, for both@stylexjs/sort-keys
and@stylexjs/valid-styles
rules.e.g. now the option accepts this format:
Additional Context
apps/nextjs-example
dir by replacing imports with react-strict-dom and configuring with the new options as in the screenshot.Pre-flight checklist
Contribution Guidelines