Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch wrong library #73

Closed
wants to merge 2 commits into from
Closed

Patch wrong library #73

wants to merge 2 commits into from

Conversation

sgxgsx
Copy link

@sgxgsx sgxgsx commented May 17, 2022

zstandard library is actually used instead of zstandard . I changed the library to zstandard in requirements.txt and changed the usage as import zstandard as zstd

Take a look at the API - https://python-zstandard.readthedocs.io/en/latest/compressor.html#zstdcompressor
And issue I created #71

zstandard library is actually used instead of zstandard .
Take a look at the API - https://python-zstandard.readthedocs.io/en/latest/compressor.html#zstdcompressor
And issue I created #71
Import zstandard as zstd
@facebook-github-bot
Copy link
Contributor

Hi @vladosstrawberry!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 17, 2022
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot
Copy link
Contributor

@0xedward has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants