Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update YGNodeStyleGetGap to return YGValue #47973

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update YGNodeStyleGetGap to return YGValue #47973

wants to merge 1 commit into from
+27 −32

Commits on Dec 3, 2024

  1. Update YGNodeStyleGetGap to return YGValue 

    Summary:
Gap can be styled using both `points` and `percentages`, but YGNodeStyleGetGap currently returns a float value.

To maintain alignment with the `padding` and `margin` functionalities and allow it to be handled in bridging code, this function has been updated to return YGValue.

X-link: facebook/yoga#1753

Reviewed By: joevilches

Differential Revision: D66513236

Pulled By: NickGerleman
    @heoblitz @facebook-github-bot
    heoblitz authored and facebook-github-bot committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    c71eacb View commit details
    Browse the repository at this point in the history