Add tests for LayoutableChildren
iterator
#47210
Open
+1
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adds unit tests that directly cover the order in which
LayoutableChildren
iterator goes over the descendant nodes. The covered cases are as follows (nodes withdisplay: contents
are marked green):Single
display: contents
nodeCorrect order:
A, D, E, C
Multiple
display: contents
nodesCorrect order:
D, E, F, G, H, I
Nested
display: contents
nodesCorrect order:
A, D, F, G, C
Leaf
display: contents
nodeCorrect order:
A, C
Root
display: contents
nodeCorrect order:
A, B, C
-LayoutableChildren
goes over the children withdisplay: contents
property, setting it on the root node should have no effect.X-link: facebook/yoga#1731
Differential Revision: D64981779
Pulled By: NickGerleman