Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

earlyjs: Integrate c++ pipeline with all ios apps #47168

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

earlyjs: Integrate c++ pipeline with all ios apps #47168

wants to merge 5 commits into from

Commits on Oct 23, 2024

  1. [skip ci] earlyjs: Make JsErrorHandler work for all js throwables (fa… 

    …cebook#47164)

Summary:

Now, handleError can be called with a JSError that wraps a non-error object!

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D64706198
    @RSNara @facebook-github-bot
    RSNara authored and facebook-github-bot committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    2be60f7 View commit details
    Browse the repository at this point in the history

  2. [skip ci] earlyjs: Make ExceptionsManager the js interface for c++ pi… 

    …peline (facebook#47165)

Summary:

The c++ pipeline needs a javascript interface.

We could just re-use exceptions manager (for now).

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D64779068
    @RSNara @facebook-github-bot
    RSNara authored and facebook-github-bot committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    07de7c9 View commit details
    Browse the repository at this point in the history

  3. [skip ci] cleanup: ExceptionsManager: Delete reportUnhandledException 

    Summary:
This method wasn't used from javascript.

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D64607415
    @RSNara @facebook-github-bot
    RSNara authored and facebook-github-bot committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    b398396 View commit details
    Browse the repository at this point in the history

  4. [skip ci] cleanup: ExceptionsManager: Delete updateExceptionMessage (f… 

    …acebook#47167)

Summary:

I couldn't find any usages of this method in javascript.

Removing, so that the native code is easier to read.

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D64606928
    @RSNara @facebook-github-bot
    RSNara authored and facebook-github-bot committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    e1449dc View commit details
    Browse the repository at this point in the history

  5. earlyjs: Integrate c++ pipeline with all ios apps 

    Summary:
Now, all ios apps will just be integrated with the c++ error reporting pipeline, with zero configuration.

Changelog: [Internal]

Differential Revision: D64615457
    @RSNara @facebook-github-bot
    RSNara authored and facebook-github-bot committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    38f7326 View commit details
    Browse the repository at this point in the history